[minor_change] Add extra missing BGP policies as new modules #519

gmicol · 2023-11-01T18:01:00Z

Add the following missing BGP policies:

BGP Peer Prefix policy
BGP Route Summarization policy
BGP Address Family Context policy

is part of issue #126

codecov · 2023-11-01T21:57:14Z

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (7ad2b51) 96.25% compared to head (ef40fb2) 96.28%.

Files	Patch %	Lines
...s/modules/aci_bgp_address_family_context_policy.py	96.00%	0 Missing and 2 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #519      +/-   ##
==========================================
+ Coverage   96.25%   96.28%   +0.02%     
==========================================
  Files         211      214       +3     
  Lines        9807     9928     +121     
  Branches     1477     1493      +16     
==========================================
+ Hits         9440     9559     +119     
  Misses        281      281              
- Partials       86       88       +2

Flag	Coverage Δ
integration	`94.63% <95.86%> (+0.01%)`	⬆️
sanity	`35.16% <39.66%> (+0.05%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

shrsr

LGTM

tests/integration/targets/aci_bgp_address_family_context_policy/tasks/main.yml

tests/integration/targets/aci_bgp_route_summarization_policy/tasks/main.yml

plugins/modules/aci_bgp_route_summarization_policy.py

tests/integration/targets/aci_bgp_route_summarization_policy/tasks/main.yml

shrsr

LGTM

plugins/modules/aci_bgp_peer_prefix_policy.py

sajagana

LGTM!

akinross

LGTM

anvitha-jain

Added test cases to increase the coverage

plugins/modules/aci_bgp_peer_prefix_policy.py

plugins/modules/aci_bgp_route_summarization_policy.py

akinross

LGTM

shrsr

LGTM

sajagana

LGTM!

lhercot

LGTM

lhercot

Fix Galaxy importer error

…ation_policy and aci_bgp_address_family_context_policy as new modules.

…peer_prefix_policy. Modify attributes for aci_bgp_address_family_context_policy.

…amily_context_policy.

…st cases.

…PIC version.

lhercot

LGTM

gmicol added the enhancement New feature or request label Nov 1, 2023

gmicol self-assigned this Nov 1, 2023

gmicol requested review from lhercot, shrsr, akinross, anvitha-jain, sajagana and samiib November 3, 2023 18:33

gmicol force-pushed the aci_extra_bgp_policies branch from 8cb08b1 to a98809e Compare November 9, 2023 19:33

shrsr previously approved these changes Nov 14, 2023

View reviewed changes

sajagana requested changes Nov 16, 2023

View reviewed changes

gmicol dismissed shrsr’s stale review via 339c211 November 17, 2023 17:01

gmicol force-pushed the aci_extra_bgp_policies branch from a98809e to 339c211 Compare November 17, 2023 17:01

gmicol requested review from sajagana and shrsr November 17, 2023 17:01

shrsr previously approved these changes Nov 17, 2023

View reviewed changes

gmicol force-pushed the aci_extra_bgp_policies branch from 339c211 to 3e436d8 Compare November 20, 2023 23:41

gmicol dismissed shrsr’s stale review via dca7d57 November 21, 2023 16:51

gmicol requested a review from shrsr November 21, 2023 16:52

anvitha-jain requested changes Nov 21, 2023

View reviewed changes

plugins/modules/aci_bgp_peer_prefix_policy.py Outdated Show resolved Hide resolved

sajagana previously approved these changes Nov 22, 2023

View reviewed changes

gmicol dismissed sajagana’s stale review via 5ab167a November 22, 2023 15:34

gmicol requested review from anvitha-jain and sajagana November 22, 2023 15:35

akinross previously approved these changes Nov 27, 2023

View reviewed changes

anvitha-jain requested changes Nov 27, 2023

View reviewed changes

plugins/modules/aci_bgp_peer_prefix_policy.py Outdated Show resolved Hide resolved

plugins/modules/aci_bgp_route_summarization_policy.py Outdated Show resolved Hide resolved

gmicol dismissed akinross’s stale review via 1c57d34 November 28, 2023 17:16

gmicol force-pushed the aci_extra_bgp_policies branch from 5ab167a to 1c57d34 Compare November 28, 2023 17:16

gmicol requested a review from anvitha-jain November 28, 2023 17:18

gmicol requested a review from akinross November 28, 2023 17:18

akinross previously approved these changes Nov 29, 2023

View reviewed changes

shrsr previously approved these changes Dec 1, 2023

View reviewed changes

sajagana previously approved these changes Dec 2, 2023

View reviewed changes

anvitha-jain previously approved these changes Dec 13, 2023

View reviewed changes

lhercot approved these changes Dec 19, 2023

View reviewed changes

lhercot requested changes Dec 19, 2023

View reviewed changes

gmicol added 10 commits December 19, 2023 17:26

[minor_change] Add aci_bgp_peer_prefix_policy, aci_bgp_route_summariz…

2f33751

…ation_policy and aci_bgp_address_family_context_policy as new modules.

[ignore] Add test cases for aci_bgp_summarization_policy and aci_bgp_…

0a101c5

…peer_prefix_policy. Modify attributes for aci_bgp_address_family_context_policy.

[ignore] Checked Sanity tests and add test case for aci_bgp_address_f…

dc2f163

…amily_context_policy.

[ignore] Modify test case for aci_bgp_route_summarization.

c5b4228

[ignore] Modify documentations, examples and add FQCN notations to te…

3d3b5dd

…st cases.

[ignore] Modify test cases and documentations to deal with previous A…

cac5781

…PIC version.

[ignore] Modify Examples for aci_bgp_route_summarization_policy.

3731a37

[ignore] Modify documentations for all BGP policies modules.

5b75e27

[ignore] Modify description of modules for BGP policies.

9317a8b

[ignore] Fix Galaxy Importer error for all extra bgp modules.

ef40fb2

gmicol dismissed stale reviews from anvitha-jain, sajagana, shrsr, and akinross via ef40fb2 December 19, 2023 22:31

gmicol force-pushed the aci_extra_bgp_policies branch from 1c57d34 to ef40fb2 Compare December 19, 2023 22:31

gmicol requested a review from lhercot December 19, 2023 22:31

lhercot approved these changes Dec 20, 2023

View reviewed changes

lhercot merged commit a1e2e95 into CiscoDevNet:master Dec 20, 2023
19 of 23 checks passed

gmicol linked an issue Dec 21, 2023 that may be closed by this pull request

L3out ansible module is incomplete #126

Closed

gmicol removed a link to an issue Dec 21, 2023

L3out ansible module is incomplete #126

Closed

gmicol mentioned this pull request Dec 21, 2023

L3out ansible module is incomplete #126

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[minor_change] Add extra missing BGP policies as new modules #519

[minor_change] Add extra missing BGP policies as new modules #519

gmicol commented Nov 1, 2023 •

edited

Loading

codecov bot commented Nov 1, 2023 •

edited

Loading

shrsr left a comment

shrsr left a comment

sajagana left a comment

akinross left a comment

anvitha-jain left a comment

akinross left a comment

shrsr left a comment

sajagana left a comment

lhercot left a comment

lhercot left a comment

lhercot left a comment

[minor_change] Add extra missing BGP policies as new modules #519

[minor_change] Add extra missing BGP policies as new modules #519

Conversation

gmicol commented Nov 1, 2023 • edited Loading

codecov bot commented Nov 1, 2023 • edited Loading

Codecov Report

shrsr left a comment

Choose a reason for hiding this comment

shrsr left a comment

Choose a reason for hiding this comment

sajagana left a comment

Choose a reason for hiding this comment

akinross left a comment

Choose a reason for hiding this comment

anvitha-jain left a comment

Choose a reason for hiding this comment

akinross left a comment

Choose a reason for hiding this comment

shrsr left a comment

Choose a reason for hiding this comment

sajagana left a comment

Choose a reason for hiding this comment

lhercot left a comment

Choose a reason for hiding this comment

lhercot left a comment

Choose a reason for hiding this comment

lhercot left a comment

Choose a reason for hiding this comment

gmicol commented Nov 1, 2023 •

edited

Loading

codecov bot commented Nov 1, 2023 •

edited

Loading