Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new Interface Protocols to configure for aci_l3out_logical_interface_profile. #593

Conversation

gmicol
Copy link
Collaborator

@gmicol gmicol commented Jan 19, 2024

is part of issue #126

@gmicol gmicol added the enhancement New feature or request label Jan 19, 2024
@gmicol gmicol self-assigned this Jan 19, 2024
Copy link

codecov bot commented Jan 19, 2024

Codecov Report

Attention: Patch coverage is 22.72727% with 17 lines in your changes are missing coverage. Please review.

Project coverage is 35.64%. Comparing base (95a9473) to head (e77cfb6).

Files Patch % Lines
...ins/modules/aci_l3out_logical_interface_profile.py 5.55% 17 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #593      +/-   ##
==========================================
- Coverage   35.67%   35.64%   -0.03%     
==========================================
  Files         250      250              
  Lines       11415    11435      +20     
  Branches     1721     1729       +8     
==========================================
+ Hits         4072     4076       +4     
- Misses       7343     7359      +16     
Flag Coverage Δ
sanity 35.64% <22.72%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gmicol gmicol force-pushed the aci_l3out_logical_interface_profile_completed_final branch from 81e2693 to d5cbd31 Compare January 25, 2024 19:06
shrsr
shrsr previously approved these changes Jan 29, 2024
Copy link
Collaborator

@shrsr shrsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

akinross
akinross previously approved these changes Jan 30, 2024
Copy link
Collaborator

@akinross akinross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTM

@gmicol gmicol dismissed stale reviews from akinross and shrsr via 5ce5a7a February 8, 2024 16:37
@gmicol gmicol requested review from sajagana, shrsr and akinross February 8, 2024 16:37
samiib
samiib previously approved these changes Feb 9, 2024
Copy link
Collaborator

@samiib samiib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

akinross
akinross previously approved these changes Feb 13, 2024
Copy link
Collaborator

@akinross akinross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lhercot
lhercot previously approved these changes Feb 27, 2024
Copy link
Member

@lhercot lhercot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmicol gmicol dismissed stale reviews from akinross and samiib via e77cfb6 February 28, 2024 01:33
@gmicol gmicol force-pushed the aci_l3out_logical_interface_profile_completed_final branch from 5ce5a7a to e77cfb6 Compare February 28, 2024 01:33
Copy link
Collaborator

@sajagana sajagana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@samiib samiib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@shrsr shrsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@lhercot lhercot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lhercot lhercot merged commit be17766 into CiscoDevNet:master Feb 28, 2024
14 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants