Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[minor_change] Add aci_l3out_bgp_protocol_profile as a new module. #491

Merged
merged 6 commits into from
Oct 19, 2023

Conversation

gmicol
Copy link
Collaborator

@gmicol gmicol commented Oct 6, 2023

is part of issue #126

@codecov
Copy link

codecov bot commented Oct 6, 2023

Codecov Report

Attention: 59 lines in your changes are missing coverage. Please review.

Comparison is base (96dddfe) 96.52% compared to head (882e75d) 35.35%.

❗ Current head 882e75d differs from pull request most recent head 826336a. Consider uploading reports for the commit 826336a to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #491       +/-   ##
===========================================
- Coverage   96.52%   35.35%   -61.17%     
===========================================
  Files         183      186        +3     
  Lines        8479     8590      +111     
  Branches     1265     1276       +11     
===========================================
- Hits         8184     3037     -5147     
- Misses        222     5553     +5331     
+ Partials       73        0       -73     
Flag Coverage Δ
integration ?
sanity 35.35% <46.84%> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
plugins/module_utils/constants.py 100.00% <100.00%> (ø)
plugins/modules/aci_l3out_logical_node_profile.py 48.48% <ø> (-51.52%) ⬇️
plugins/modules/aci_bgp_best_path_policy.py 51.51% <51.51%> (ø)
plugins/modules/aci_bgp_timers_policy.py 45.94% <45.94%> (ø)
plugins/modules/aci_l3out_bgp_protocol_profile.py 41.02% <41.02%> (ø)

... and 177 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gmicol gmicol self-assigned this Oct 6, 2023
@gmicol gmicol added the enhancement New feature or request label Oct 6, 2023
plugins/modules/aci_bgp_best_path_policy.py Outdated Show resolved Hide resolved
plugins/modules/aci_bgp_best_path_policy.py Show resolved Hide resolved
plugins/modules/aci_bgp_timers_policy.py Show resolved Hide resolved
@gmicol gmicol force-pushed the aci_l3out_bgp_protocol_profile branch from 6882508 to 826336a Compare October 12, 2023 17:35
@gmicol gmicol requested a review from akinross October 12, 2023 17:36
Copy link
Collaborator

@akinross akinross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@sajagana sajagana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@shrsr shrsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@lhercot lhercot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lhercot lhercot merged commit ec089bd into CiscoDevNet:master Oct 19, 2023
17 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants