Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[minor_change] Add route control profile as a new module. #479

Merged
merged 11 commits into from
Nov 2, 2023
Merged

[minor_change] Add route control profile as a new module. #479

merged 11 commits into from
Nov 2, 2023

Conversation

gmicol
Copy link
Collaborator

@gmicol gmicol commented Sep 22, 2023 •
edited
Loading

is part of issue #126

@gmicol gmicol self-assigned this Sep 22, 2023
@codecov
Copy link

codecov bot commented Sep 22, 2023 •
edited
Loading

Codecov Report

Attention: 276 lines in your changes are missing coverage. Please review.

Comparison is base (d3264a6) 96.53% compared to head (008c758) 35.65%.
Report is 30 commits behind head on master.

❗ Current head 008c758 differs from pull request most recent head 04e8886. Consider uploading reports for the commit 04e8886 to get more accurate results

Additional details and impacted files 
@@             Coverage Diff             @@
##           master     #479       +/-   ##
===========================================
- Coverage   96.53%   35.65%   -60.88%     
===========================================
  Files         183      194       +11     
  Lines        8448     8876      +428     
  Branches     1256     1304       +48     
===========================================
- Hits         8155     3165     -4990     
- Misses        222     5711     +5489     
+ Partials       71        0       -71
Flag Coverage Δ
integration ?
sanity 35.65% <39.86%> (+0.34%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
plugins/module_utils/constants.py 100.00% <100.00%> (ø)
...ci_access_port_to_interface_policy_leaf_profile.py 27.69% <ø> (-70.77%) ⬇️
plugins/modules/aci_config_snapshot.py 31.25% <ø> (-68.75%) ⬇️
plugins/modules/aci_l3out_logical_node_profile.py 48.48% <ø> (-51.52%) ⬇️
plugins/modules/aci_snmp_user.py 45.45% <0.00%> (-54.55%) ⬇️
plugins/httpapi/aci.py 17.98% <20.00%> (-75.41%) ⬇️
plugins/module_utils/aci.py 11.47% <14.28%> (-63.22%) ⬇️
plugins/modules/aci_config_rollback.py 30.98% <0.00%> (-61.44%) ⬇️
plugins/modules/aci_l3out_logical_node.py 32.60% <0.00%> (-67.40%) ⬇️
plugins/modules/aci_match_rule.py 51.61% <51.61%> (ø)
... and 11 more

... and 169 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gmicol
[minor_changes] Add aci_match_community_factor and all test cases for…
da80422 
… route control profile and Match rules related modules.
@gmicol
[ignore] Modify documentations and check sanity tests for all modules…
0dcf72c 
… related to aci_route_control_profile.
akinross
akinross requested changes Sep 29, 2023
View reviewed changes
plugins/modules/aci_context_policy.py Outdated Show resolved Hide resolved
plugins/modules/aci_context_policy.py Outdated Show resolved Hide resolved
plugins/modules/aci_context_policy.py Outdated Show resolved Hide resolved
plugins/modules/aci_context_policy.py Outdated Show resolved Hide resolved
plugins/modules/aci_context_policy.py Outdated Show resolved Hide resolved
plugins/modules/aci_match_route_destination.py Outdated Show resolved Hide resolved
plugins/modules/aci_context_policy.py Outdated Show resolved Hide resolved
plugins/modules/aci_route_control_profile.py Show resolved Hide resolved
plugins/modules/aci_context_policy.py Outdated Show resolved Hide resolved
plugins/modules/aci_route_control_profile.py Outdated Show resolved Hide resolved
@gmicol
[minor_change] Rename module aci_context_policy and aci_subject_profi…
5d7acdb 
…le to aci_route_control_context and aci_match_rule. Applied changes to all Documentations and Modules.
@gmicol gmicol requested a review from akinross October 5, 2023 14:10
@gmicol gmicol added the enhancement New feature or request label Oct 6, 2023
shrsr
shrsr requested changes Oct 11, 2023
View reviewed changes
plugins/modules/aci_match_as_path_regex_term.py Outdated Show resolved Hide resolved
plugins/modules/aci_match_as_path_regex_term.py Outdated Show resolved Hide resolved
plugins/modules/aci_match_as_path_regex_term.py Outdated Show resolved Hide resolved
plugins/modules/aci_match_community_factor.py Outdated Show resolved Hide resolved
anvitha-jain
anvitha-jain requested changes Oct 11, 2023
View reviewed changes
tests/integration/targets/aci_route_control_profile/tasks/main.yml Outdated Show resolved Hide resolved
tests/integration/targets/aci_match_as_path_regex_term/tasks/main.yml Outdated Show resolved Hide resolved
tests/integration/targets/aci_match_community_factor/tasks/main.yml Outdated Show resolved Hide resolved
tests/integration/targets/aci_match_community_regex_term/tasks/main.yml Outdated Show resolved Hide resolved
tests/integration/targets/aci_match_community_term/tasks/main.yml Outdated Show resolved Hide resolved
tests/integration/targets/aci_match_route_destination/tasks/main.yml Outdated Show resolved Hide resolved
tests/integration/targets/aci_match_rule/tasks/main.yml Outdated Show resolved Hide resolved
tests/integration/targets/aci_route_control_context/tasks/main.yml Outdated Show resolved Hide resolved
@gmicol gmicol requested review from shrsr and anvitha-jain October 12, 2023 16:55
shrsr
shrsr previously approved these changes Oct 16, 2023
View reviewed changes
Copy link
Collaborator

@shrsr shrsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

akinross
akinross previously approved these changes Oct 18, 2023
View reviewed changes
Copy link
Collaborator

@akinross akinross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

anvitha-jain
anvitha-jain previously approved these changes Oct 18, 2023
View reviewed changes
sajagana
sajagana requested changes Oct 20, 2023
View reviewed changes
tests/integration/targets/aci_match_route_destination/tasks/main.yml Outdated Show resolved Hide resolved
plugins/modules/aci_match_as_path_regex_term.py Outdated Show resolved Hide resolved
plugins/modules/aci_match_community_factor.py Outdated Show resolved Hide resolved
plugins/modules/aci_match_community_regex_term.py Outdated Show resolved Hide resolved
plugins/modules/aci_match_community_term.py Outdated Show resolved Hide resolved
@gmicol gmicol dismissed stale reviews from akinross and shrsr via 04e8886 October 24, 2023 17:50
akinross
akinross approved these changes Oct 24, 2023
View reviewed changes
Copy link
Collaborator

@akinross akinross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

shrsr
shrsr approved these changes Oct 24, 2023
View reviewed changes
Copy link
Collaborator

@shrsr shrsr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sajagana
sajagana approved these changes Oct 25, 2023
View reviewed changes
Copy link
Collaborator

@sajagana sajagana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

lhercot
lhercot approved these changes Nov 2, 2023
View reviewed changes
Copy link
Member

@lhercot lhercot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lhercot lhercot merged commit 6906a3e into CiscoDevNet:master Nov 2, 2023
17 of 21 checks passed
@lhercot lhercot mentioned this pull request Dec 20, 2023
Closed
@gmicol gmicol mentioned this pull request Dec 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sajagana sajagana sajagana approved these changes

@akinross akinross akinross approved these changes

@shrsr shrsr shrsr approved these changes

@lhercot lhercot lhercot approved these changes

@anvitha-jain anvitha-jain Awaiting requested review from anvitha-jain anvitha-jain is a code owner

Assignees

@gmicol gmicol

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@gmicol @lhercot @shrsr @akinross @anvitha-jain @sajagana