Feat/aci l3out route profile #283

timcragg · 2022-05-24T15:05:34Z

This PR adds modules and integration tests for the following objects:

rtctrlProfile
rtctrlCtxP
rtctrlAttrP
rtctrlRsCtxPToSubjP
rtctrlMatchRtDest
rtctrlScope
rtctrlSetComm
rtctrlSubjP
l3extRsInstPToProfile

Co-authored-by: Akini Ross <[email protected]>

plugins/modules/aci_l3out_extepg_to_route_control_profile.py

plugins/modules/aci_route_control_context.py

plugins/modules/aci_route_control_set_comm.py

plugins/modules/aci_route_control_profile.py

plugins/modules/aci_route_context_scope.py

akinross

LGTM

plugins/modules/aci_route_control_match_dest.py

anvitha-jain

LGTM

plugins/modules/aci_route_control_set_comm.py

akinross

LGTM

anvitha-jain

LGTM

plugins/modules/aci_route_control_attr.py

plugins/modules/aci_route_control_subject.py

plugins/modules/aci_route_control_set_comm.py

lhercot · 2023-12-20T14:35:36Z

Closing this PR as the code has been incorporated in PR #495 and #479 see PRs for small changes introduced in the review process.

Thanks for your contribution!

timcragg added 30 commits May 19, 2022 16:21

feat: Add route control modules

d8f9b24

feat: add integration test

95ff229

fix: sanity check fixes

8aecac0

fix: sanity test fixes

dd79932

fix: Sanity test fixes

eeaa34a

feat: add integration test

7aec63b

feat: context integration test

4b596b2

fix: correct integration test

dc6711e

feat: add rtctrl subject integration test

bb1ff36

fix: corrections

cdd71dd

fix: Correct integration test

2516074

feat: Add rtctrl match dest integration test

702b17e

fix: correct paths

a32fee9

feat: add integration test for rtctrl attr

1d26b33

fix: correct integration test

0f173fe

fix: correct integration test

a6326da

fix: correct integration test

52debe1

fix: correct integration test

5fca164

feat: Integration test for rtctrlSetComm

11a94b8

feat: Add integration test for rtctrlRsCtxPToSubjP

64073ae

fix: correct integration test

bab7aae

fix: correct integration test

a0b0f8c

fix: Correct integration test

9f1eb55

feat: Add integration test for rtctrlScope

41610c2

fix: correct docs

b7b90cc

fix: Correct integration tests

b0cd0f6

fix: Correct integration tests

22a4aba

feat: Integration test for l3extRsInstPToProfile

e7237a5

fix: correct integration tests

1d80685

fix: correct integration test

04915d0

timcragg and others added 4 commits April 18, 2023 14:24

Update plugins/modules/aci_route_control_context.py

c0df5e8

Co-authored-by: Akini Ross <[email protected]>

fix: Minor fixes

eb41ba7

fix: Update integration tests

8b178f3

fix: Minor updates

f0811c2

timcragg requested a review from akinross April 25, 2023 09:04

akinross requested changes Apr 26, 2023

View reviewed changes

plugins/modules/aci_l3out_extepg_to_route_control_profile.py Show resolved Hide resolved

plugins/modules/aci_route_control_context.py Show resolved Hide resolved

plugins/modules/aci_route_control_set_comm.py Outdated Show resolved Hide resolved

akinross reviewed Apr 26, 2023

View reviewed changes

plugins/modules/aci_route_control_profile.py Outdated Show resolved Hide resolved

akinross reviewed Apr 26, 2023

View reviewed changes

plugins/modules/aci_route_control_profile.py Outdated Show resolved Hide resolved

akinross reviewed Apr 26, 2023

View reviewed changes

plugins/modules/aci_route_context_scope.py Outdated Show resolved Hide resolved

timcragg added 2 commits April 26, 2023 14:24

fix: Update description

2dba685

fix: Sanity fix

8f710f6

akinross self-requested a review April 26, 2023 14:34

akinross previously approved these changes Apr 26, 2023

View reviewed changes

anvitha-jain requested changes May 2, 2023

View reviewed changes

plugins/modules/aci_route_control_match_dest.py Show resolved Hide resolved

chore: update bool format in tests

9fc250f

timcragg dismissed akinross’s stale review via 9fc250f June 21, 2023 09:53

timcragg requested a review from akinross June 21, 2023 09:59

akinross requested a review from anvitha-jain June 21, 2023 10:15

anvitha-jain previously approved these changes Jun 21, 2023

View reviewed changes

akinross requested changes Jun 22, 2023

View reviewed changes

plugins/modules/aci_route_control_set_comm.py Show resolved Hide resolved

chore: Update integration tests

62dd329

timcragg dismissed anvitha-jain’s stale review via 62dd329 June 22, 2023 13:27

akinross requested review from anvitha-jain and akinross June 22, 2023 13:41

akinross approved these changes Jun 22, 2023

View reviewed changes

anvitha-jain approved these changes Jun 27, 2023

View reviewed changes

lhercot requested changes Jul 19, 2023

View reviewed changes

plugins/modules/aci_route_control_attr.py Show resolved Hide resolved

plugins/modules/aci_route_control_subject.py Show resolved Hide resolved

plugins/modules/aci_route_control_set_comm.py Show resolved Hide resolved

akinross assigned gmicol Sep 29, 2023

lhercot closed this Dec 20, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feat/aci l3out route profile #283

Feat/aci l3out route profile #283

timcragg commented May 24, 2022

akinross left a comment

anvitha-jain left a comment

akinross left a comment

anvitha-jain left a comment

lhercot commented Dec 20, 2023

Feat/aci l3out route profile #283

Feat/aci l3out route profile #283

Conversation

timcragg commented May 24, 2022

akinross left a comment

Choose a reason for hiding this comment

anvitha-jain left a comment

Choose a reason for hiding this comment

akinross left a comment

Choose a reason for hiding this comment

anvitha-jain left a comment

Choose a reason for hiding this comment

lhercot commented Dec 20, 2023