ACI tenant action rule profile extended #495

gmicol · 2023-10-13T17:58:31Z

is part of issue #126

codecov · 2023-10-13T21:40:29Z

Codecov Report

Attention: 75 lines in your changes are missing coverage. Please review.

Comparison is base (7ad2b51) 96.25% compared to head (554c702) 35.15%.

Files	Patch %	Lines
plugins/modules/aci_tenant_action_rule_profile.py	7.69%	24 Missing ⚠️
.../modules/aci_action_rule_additional_communities.py	46.87%	17 Missing ⚠️
plugins/modules/aci_action_rule_set_as_path.py	46.87%	17 Missing ⚠️
plugins/modules/aci_action_rule_set_as_path_asn.py	46.87%	17 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           master     #495       +/-   ##
===========================================
- Coverage   96.25%   35.15%   -61.11%     
===========================================
  Files         211      214        +3     
  Lines        9807     9933      +126     
  Branches     1477     1499       +22     
===========================================
- Hits         9440     3492     -5948     
- Misses        281     6441     +6160     
+ Partials       86        0       -86

Flag	Coverage Δ
integration	`?`
sanity	`35.15% <40.94%> (+0.04%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

plugins/modules/aci_action_rule_additional_communities.py

tests/integration/inventory.networking

plugins/modules/aci_action_rule_set_as_path.py

plugins/modules/aci_action_rule_additional_communities.py

plugins/modules/aci_action_rule_set_as_path.py

plugins/modules/aci_tenant_action_rule_profile.py

plugins/module_utils/aci.py

plugins/modules/aci_tenant_action_rule_profile.py

plugins/module_utils/aci.py

plugins/modules/aci_tenant_action_rule_profile.py

plugins/module_utils/aci.py

plugins/modules/aci_tenant_action_rule_profile.py

samiib

LGTM

tests/integration/targets/aci_tenant_action_rule_profile/tasks/main.yml

plugins/modules/aci_tenant_action_rule_profile.py

tests/integration/targets/aci_action_rule_additional_communities/tasks/main.yml

tests/integration/targets/aci_action_rule_set_as_path/tasks/main.yml

tests/integration/targets/aci_action_rule_set_as_path_asn/tasks/main.yml

tests/integration/targets/aci_action_rule_additional_communities/tasks/main.yml

akinross

please address the forgotten open comment regarding FQCN

plugins/modules/aci_action_rule_additional_communities.py

shrsr

LGTM

sajagana · 2023-11-16T10:28:01Z

plugins/modules/aci_tenant_action_rule_profile.py

+        child_configs = []
+        for class_name, attribute in child_classes.items():
+            attribute_input = attribute.get("attribute_input")
+            # This condition enables to user to keep its previous configurations if they are not passing anyting in the payload.


Suggested change

# This condition enables to user to keep its previous configurations if they are not passing anyting in the payload.

# This condition enables to user to keep its previous configurations if they are not passing anything in the payload.

shrsr

LGTM

samiib

LGTM

sajagana

LGTM!

lhercot

LGTM

…dule and Add action rules attributes to aci_tenant_action_rule_profile.

…t_as_path_asn as new modules.

…_tenant_action_rule_profile.

…n and add test cases for all missing action rules.

…file, modify documentations and examples for all other modules.

… python files to pass Sanity tests for aci_tenant_action_rule_profile.

…action_rule_profile.

…o deal with non-exsiting child classes for APIC version prior to 5.0

…notation in all test cases for aci_tenant_action_rule_profile.

…rofile.

…ommunitties

lhercot

LGTM

gmicol added the enhancement New feature or request label Oct 13, 2023

gmicol self-assigned this Oct 13, 2023

gmicol requested review from lhercot, shrsr, akinross, anvitha-jain, sajagana and samiib October 26, 2023 18:03

samiib requested changes Oct 27, 2023

View reviewed changes

plugins/modules/aci_action_rule_additional_communities.py Show resolved Hide resolved

tests/integration/inventory.networking Outdated Show resolved Hide resolved

akinross requested changes Oct 27, 2023

View reviewed changes

gmicol force-pushed the aci_tenant_action_rule_profile-extended branch from 2a4f5f0 to c06c7e9 Compare October 30, 2023 17:28

gmicol requested review from samiib and akinross October 30, 2023 17:48

akinross requested changes Nov 1, 2023

View reviewed changes

gmicol force-pushed the aci_tenant_action_rule_profile-extended branch from d172327 to 6dcc43b Compare November 1, 2023 19:45

gmicol requested a review from akinross November 1, 2023 19:45

samiib previously approved these changes Nov 1, 2023

View reviewed changes

akinross requested changes Nov 2, 2023

View reviewed changes

gmicol dismissed samiib’s stale review via 96d3877 November 3, 2023 17:22

gmicol requested review from akinross and samiib November 3, 2023 17:23

akinross requested changes Nov 3, 2023

View reviewed changes

gmicol requested a review from akinross November 6, 2023 18:04

gmicol force-pushed the aci_tenant_action_rule_profile-extended branch from 6d5ee77 to ab49828 Compare November 9, 2023 19:35

shrsr requested changes Nov 14, 2023

View reviewed changes

plugins/modules/aci_action_rule_additional_communities.py Outdated Show resolved Hide resolved

plugins/modules/aci_action_rule_additional_communities.py Outdated Show resolved Hide resolved

plugins/modules/aci_action_rule_additional_communities.py Outdated Show resolved Hide resolved

gmicol requested a review from shrsr November 15, 2023 17:15

shrsr previously approved these changes Nov 15, 2023

View reviewed changes

sajagana requested changes Nov 16, 2023

View reviewed changes

gmicol dismissed shrsr’s stale review via b2d6dc4 November 16, 2023 16:42

shrsr self-requested a review November 22, 2023 16:54

shrsr previously approved these changes Nov 22, 2023

View reviewed changes

samiib previously approved these changes Dec 13, 2023

View reviewed changes

sajagana previously approved these changes Dec 18, 2023

View reviewed changes

lhercot previously approved these changes Dec 19, 2023

View reviewed changes

gmicol added 14 commits December 19, 2023 17:32

[minor_change] Add aci_action_rule_additional_communities as a new mo…

b544bff

…dule and Add action rules attributes to aci_tenant_action_rule_profile.

[minor_change] Add aci_action_rule_set_as_path and aci_action_rule_se…

616f02f

…t_as_path_asn as new modules.

[minor_change] Add additional missing action rules as children in aci…

36a41a2

…_tenant_action_rule_profile.

[ignore] Modify conditions for aci_tenant_action_rule_profile childre…

86d65a2

…n and add test cases for all missing action rules.

[ignore] Modify conditions for children in aci_tenant_action_rule_pro…

b2a6c1e

…file, modify documentations and examples for all other modules.

[ignore] Add test case for aci_action_rule_set_as_path_asn and Modify…

ae579ba

… python files to pass Sanity tests for aci_tenant_action_rule_profile.

[ignore] Modify conditions to configure child objects for aci_tenant_…

5d0fe69

…action_rule_profile.

[ignore] Apply Black on aci_tenant_action_rule_profile.

460e7b0

[ignore] Modify aci_tenant_action_rule_profile module and test case t…

ed9f165

…o deal with non-exsiting child classes for APIC version prior to 5.0

[ignore] Apply Black on aci_tenant_action_rule_profile.py

66bf837

[ignore] Modify conditions to add missing child classes and add FQCN …

3b6c644

…notation in all test cases for aci_tenant_action_rule_profile.

[ignore] Made all the test cases cleaner for aci_tenant_action_rule_p…

66f1dfd

…rofile.

[ignore] Modify the Examples section for aci_action_rule_additional_c…

649b7f7

…ommunitties

[ignore] Modify comments in aci_tenant_action_rule_profile.

554c702

gmicol dismissed stale reviews from lhercot, sajagana, samiib, shrsr, akinross, and anvitha-jain via 554c702 December 19, 2023 22:40

gmicol force-pushed the aci_tenant_action_rule_profile-extended branch from 5150474 to 554c702 Compare December 19, 2023 22:40

lhercot approved these changes Dec 20, 2023

View reviewed changes

lhercot merged commit 88233f9 into CiscoDevNet:master Dec 20, 2023
17 of 23 checks passed

lhercot mentioned this pull request Dec 20, 2023

Feat/aci l3out route profile #283

Closed

gmicol mentioned this pull request Dec 21, 2023

L3out ansible module is incomplete #126

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ACI tenant action rule profile extended #495

ACI tenant action rule profile extended #495

gmicol commented Oct 13, 2023 •

edited

Loading

codecov bot commented Oct 13, 2023 •

edited

Loading

samiib left a comment

akinross left a comment

shrsr left a comment

sajagana Nov 16, 2023

shrsr left a comment

samiib left a comment

sajagana left a comment

lhercot left a comment

lhercot left a comment

	# This condition enables to user to keep its previous configurations if they are not passing anyting in the payload.
	# This condition enables to user to keep its previous configurations if they are not passing anything in the payload.

ACI tenant action rule profile extended #495

ACI tenant action rule profile extended #495

Conversation

gmicol commented Oct 13, 2023 • edited Loading

codecov bot commented Oct 13, 2023 • edited Loading

Codecov Report

samiib left a comment

Choose a reason for hiding this comment

akinross left a comment

Choose a reason for hiding this comment

shrsr left a comment

Choose a reason for hiding this comment

sajagana Nov 16, 2023

Choose a reason for hiding this comment

shrsr left a comment

Choose a reason for hiding this comment

samiib left a comment

Choose a reason for hiding this comment

sajagana left a comment

Choose a reason for hiding this comment

lhercot left a comment

Choose a reason for hiding this comment

lhercot left a comment

Choose a reason for hiding this comment

gmicol commented Oct 13, 2023 •

edited

Loading

codecov bot commented Oct 13, 2023 •

edited

Loading