Add PIM interface policy modules #537

gmicol · 2023-11-28T19:26:43Z

Missing Classes:

pimIfPol
pimRouteMapPolicy
pimRouteMapEntry

is part of issue #126

codecov · 2023-11-28T19:30:45Z

Codecov Report

Attention: 75 lines in your changes are missing coverage. Please review.

Comparison is base (8bb7138) 96.27% compared to head (7b37c61) 35.54%.

Files	Patch %	Lines
plugins/modules/aci_interface_policy_pim.py	28.81%	42 Missing ⚠️
plugins/modules/aci_pim_route_map_entry.py	45.71%	19 Missing ⚠️
plugins/modules/aci_pim_route_map_policy.py	53.33%	14 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           master     #537       +/-   ##
===========================================
- Coverage   96.27%   35.54%   -60.74%     
===========================================
  Files         238      241        +3     
  Lines       10898    11024      +126     
  Branches     1637     1658       +21     
===========================================
- Hits        10492     3918     -6574     
- Misses        308     7106     +6798     
+ Partials       98        0       -98

Flag	Coverage Δ
integration	`?`
sanity	`35.54% <40.47%> (+0.05%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

gmicol · 2023-12-05T08:16:37Z

Modules and test cases added:

aci_interface_policy_pim
aci_pim_route_map_policy
aci_pim_route_map_entry

plugins/modules/aci_pim_route_map_entry.py

plugins/modules/aci_pim_route_map_policy.py

plugins/modules/aci_interface_policy_pim.py

plugins/modules/aci_pim_route_map_entry.py

akinross

LGTM

tests/integration/targets/aci_interface_policy_pim/tasks/main.yml

samiib

LGTM

plugins/modules/aci_interface_policy_pim.py

plugins/modules/aci_pim_route_map_entry.py

plugins/modules/aci_pim_route_map_policy.py

plugins/modules/aci_interface_policy_pim.py

akinross

LGTM

plugins/modules/aci_interface_policy_pim.py

plugins/modules/aci_pim_route_map_entry.py

…ry as new modules.

… aci_interface_policy_pim.

… python files.

…interface_policy_pim.

…_policy_pim python files.

akinross

LGTM

sajagana

LGTM!

shrsr

LGTM

lhercot

LGTM

gmicol added the enhancement New feature or request label Nov 28, 2023

gmicol self-assigned this Nov 28, 2023

gmicol changed the title ~~Add missing Modules and children classes for aci_l3out_logical_interface_profile.~~ Add missing Modules and child classes for aci_l3out_logical_interface_profile. Nov 28, 2023

gmicol requested review from lhercot, shrsr, akinross, anvitha-jain, sajagana and samiib December 5, 2023 08:19

anvitha-jain requested changes Dec 7, 2023

View reviewed changes

gmicol requested a review from anvitha-jain December 8, 2023 18:19

anvitha-jain previously approved these changes Dec 13, 2023

View reviewed changes

akinross requested changes Dec 13, 2023

View reviewed changes

gmicol changed the title ~~Add missing Modules and child classes for aci_l3out_logical_interface_profile.~~ Add PIM interface policy modules Dec 13, 2023

gmicol dismissed anvitha-jain’s stale review via 5fece1e December 14, 2023 11:57

gmicol force-pushed the aci_l3out_logical_inferface_profile-extended branch from 3c19e8f to 5fece1e Compare December 14, 2023 11:57

gmicol requested review from akinross and anvitha-jain December 14, 2023 11:57

akinross previously approved these changes Dec 14, 2023

View reviewed changes

akinross reviewed Dec 14, 2023

View reviewed changes

tests/integration/targets/aci_interface_policy_pim/tasks/main.yml Show resolved Hide resolved

gmicol mentioned this pull request Dec 21, 2023

L3out ansible module is incomplete #126

Closed

anvitha-jain requested changes Dec 21, 2023

View reviewed changes

tests/integration/targets/aci_interface_policy_pim/tasks/main.yml Show resolved Hide resolved

samiib previously approved these changes Dec 22, 2023

View reviewed changes

shrsr requested changes Dec 22, 2023

View reviewed changes

plugins/modules/aci_interface_policy_pim.py Outdated Show resolved Hide resolved

plugins/modules/aci_interface_policy_pim.py Outdated Show resolved Hide resolved

plugins/modules/aci_interface_policy_pim.py Show resolved Hide resolved

gmicol dismissed stale reviews from samiib and akinross via 9a872cb January 9, 2024 15:49

gmicol force-pushed the aci_l3out_logical_inferface_profile-extended branch from 5fece1e to 9a872cb Compare January 9, 2024 15:49

akinross previously approved these changes Jan 22, 2024

View reviewed changes

sajagana requested changes Jan 22, 2024

View reviewed changes

plugins/modules/aci_interface_policy_pim.py Outdated Show resolved Hide resolved

plugins/modules/aci_pim_route_map_entry.py Outdated Show resolved Hide resolved

gmicol added 16 commits January 22, 2024 12:23

[minor_change] Add aci_interface_policy_pim as a new module.

34b7ce7

[ignore] Modify argument_spec for aci_interface_policy_pim

9b8104b

[minor_change] Add aci_pim_route_map_policy and aci_pim_route_map_ent…

9313c73

…ry as new modules.

[ignore] Modify construct_url for aci_pim_route_map_entry.

daaa9fa

[ignore] Pass Sanity tests for new python files.

52ffb97

[ignore] Add test cases for all PIM interface policy related modules.

60e41b9

[ignore] Apply Black on PIM interface policy related python files.

046e585

[ignore] Modify documentation for all the new PIM modules.

e326034

[ignore] Modify documentations and aliases for all modules related to…

390ae9e

… aci_interface_policy_pim.

[ignore] Add Update tasks to test files and Modify documentations for…

6916a92

… python files.

[ignore] Apply Black to aci_interface_policy_pim.

c6195fe

[ignore] Applied Black on constants.py file.

4d07990

[ignore] Applied Black again on constants.py file.

0584261

[ignore] Correct mispelling of 'designated_router' attributes in aci_…

311222f

…interface_policy_pim.

[ignore] Remove dupplicates from constant.py

ffae076

[ignore] Update examples in aci_pim_route_map_entry and aci_interface…

7b37c61

…_policy_pim python files.

gmicol dismissed stale reviews from akinross and shrsr via 7b37c61 January 22, 2024 17:28

gmicol force-pushed the aci_l3out_logical_inferface_profile-extended branch from 9dfab0a to 7b37c61 Compare January 22, 2024 17:28

gmicol requested review from sajagana, shrsr and akinross January 22, 2024 17:28

akinross approved these changes Jan 22, 2024

View reviewed changes

anvitha-jain approved these changes Jan 22, 2024

View reviewed changes

sajagana approved these changes Jan 23, 2024

View reviewed changes

shrsr approved these changes Jan 23, 2024

View reviewed changes

lhercot approved these changes Jan 23, 2024

View reviewed changes

lhercot merged commit f3b017f into CiscoDevNet:master Jan 23, 2024
14 of 17 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add PIM interface policy modules #537

Add PIM interface policy modules #537

gmicol commented Nov 28, 2023 •

edited

Loading

codecov bot commented Nov 28, 2023 •

edited

Loading

gmicol commented Dec 5, 2023

akinross left a comment

samiib left a comment

akinross left a comment

akinross left a comment

sajagana left a comment

shrsr left a comment

lhercot left a comment

Add PIM interface policy modules #537

Add PIM interface policy modules #537

Conversation

gmicol commented Nov 28, 2023 • edited Loading

codecov bot commented Nov 28, 2023 • edited Loading

Codecov Report

gmicol commented Dec 5, 2023

akinross left a comment

Choose a reason for hiding this comment

samiib left a comment

Choose a reason for hiding this comment

akinross left a comment

Choose a reason for hiding this comment

akinross left a comment

Choose a reason for hiding this comment

sajagana left a comment

Choose a reason for hiding this comment

shrsr left a comment

Choose a reason for hiding this comment

lhercot left a comment

Choose a reason for hiding this comment

gmicol commented Nov 28, 2023 •

edited

Loading

codecov bot commented Nov 28, 2023 •

edited

Loading