Resolve the conflicts to merge to the master #13337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* WIP * WIP * WIP * WIP * Add last two to workspace * Add basic READMEs and test builds * Add basic READMEs and test builds * Fix package versions * Skip tests * Address feedback * Address feedback * Rerun swagger codegen * Rerun swagger codegen * Add rolled up type files * WIP * WIP * New regeneration with tracing * New regeneration with tracing * Remove prepack * Add sdk-type * Add lint * Skip lint for now * Add copyright and improve generation * Add copyright and improve generation * Fix keyvault lint * Export fixes * Export fixes * Fix release dates
* Increment package version after release of azure-storage-blob * Increment package version after release of azure-storage-file-datalake * Increment package version after release of azure-storage-file-share * Increment package version after release of azure-storage-queue
…2796) * [test-utils-recorder] Refactored recorder to separate node.js dependencies * Repaired metricsadvisor build * Repaired textanalytics build * Repaired formrecognizer build * Repaired template build * Fixed base rollup config * Updated CHANGELOG for recorder * Removed some no-longer-used dependencies and options. * Added `chai` to imports (How was this not a type error??) * Apply suggestions from code review Co-authored-by: Harsha Nalluru <[email protected]> * Removed unused 'env' import Co-authored-by: Harsha Nalluru <[email protected]>
Fix a strictness issue in `utils/encode.ts` in #12745.
Co-authored-by: Sima Zhu <[email protected]>
* Add PR CI step to build samples * Made a change to rush-runner * Fixed an issue with rush-runner patch * Repaired metricsadvisor and anomalydetector samples builds * Repaired storage samples build scripts, added skip to storage-internal-avro * Added skips to core packages without samples * Resolved conflicting options in identity samples * Skipped broken test scripts * pnpm-lock * [eventhubs-checkpointstore-blob] fix build:samples script (#3) * [event-processor-host] fix build:samples script * Revert sorting of package.json script entries * Fixed merge artifact in dev-tool package.json * pnpm-lock * Revert formatting changes to anomalydetector * Run build phase with transitive dependencies. * Add stub build:samples commands for synapse * Added samples build setup for tables * Repaired two broken links in EPH Co-authored-by: chradek <[email protected]> Co-authored-by: chradek <[email protected]>
Co-authored-by: Shuang Jiang <[email protected]>
…for usingAadAuth.js (#12818) There were several issues causing the smoke tests to not be a useful signal - this PR improves on the situation and gets us back to green. There are still some issues that require followup which I'll be filing soon. Fixes: * ServiceBus was only whitelisting a single sample (usingAadAuth.js) which _used_ to pass but only because it wasn't doing any real work. When we changed it awhile back to actually attempt to use it's connection it failed. This still needs some investigation but in the meantime I've swapped it out and brought in some more useful samples like sendMessages.js, browseMessages.js and sessions.js, which should give us some coverage. This also required altering the test-resources.json so it properly created the sample queues as well as outputting them so they'd get set in the environment. * FormRecognizer had some failing samples. After talking with @willmtemple I ignored one of them that will require some actual test data to be bootstrapped reasonably (so not necessarily a good candidate for this). I fixed another one that appeared to just not handle some data being empty (seems legitimate, but perhaps it's a bug).d up in the sample's environment. Fixes #12803
* resolve git longpath error when applying documentation updates Co-authored-by: scbedd <[email protected]>
* Added a step of skipping package json update for spring boot packages * Added skip package json config * Update the indentation Co-authored-by: Sima Zhu <[email protected]>
* Support alpha and azure pipeline build version formats for SemVer parsing and sorting * Minor build number fixes * Support zero-padding of build versions more generically in SemVer script * Fix pre-release label conditional for HasValidPrereleaseLabel in semver script * Set default convention for build number separator in semver script Co-authored-by: Ben Broderick Phillips <[email protected]>
Being able to use `rush clean` is blocked on these commands being defined.
* upgrade TS version and fix compilation issues * upgrade the linting parser version and fix new linting issues * fix cosmos sample * address feedback * fix linting issues in formrecognizer tests * use unknown instead of any across our code * address more issues * cleanup package.json in core-http * revert noisy linting changes caused by vanilla eslint rules not TS aware * allow the poller to have results of type void * fixing samples * fix keyvault-certificates' sample
…12893) * OT Exporter use Resources API to get service properties * Test * Addung pnpm-lock * Addressing comments * Updating pnpm
Co-authored-by: Sima Zhu <[email protected]>
…to keep the event listeners in place until we actually resolve the promise. (#12908) When we went down the 'drain' path with BatchingReceiver we'd actually remove the event listeners. With the old code this could happen: 1. message received, debounce timer set 2. debounce timer fires 3. drain is requested (also removed the event listeners!) 4. message arrives (ignored) 5. receiver_drain arrives and resolve's the promise but the message in step 4 is lost. The simplest way to reproduce this was to just connect over a slower link (created an SB in AU, which is slower than connecting over to something in the US) and send some about 100 messages (I used 2k-ish of text for each one) - this made it more likely that you'd end up with only a partial transfer of messages and have a drain. This became even more obvious once we moved to scheduling the promise resolution with setTimeout() as it widened the gap (this bug was less easy to see before!). Many thanks to @enoeden for finding this bug! Fixes #12711
# Status quo Some of our documentation comments are [TypeDoc](http://typedoc.org/guides/doccomments/) and some of them are JSDoc with type description in the comments even though it is for typed TS code. # Standardization I decided the best way to go about this is to migrate to [TSDoc](https://github.com/Microsoft/tsdoc) and enforcing it using the [tsdoc eslint plugin](https://www.npmjs.com/package/eslint-plugin-tsdoc). Pros: - TSDoc is a proposal to standardize the doc comments used in TypeScript code, so that different tools can extract content without getting confused by each other’s markup. - It is being developed at Microsoft, with the TypeScript team. - It has an ESLint plugin that enforces it and will error when it sees unsupported tags (e.g. `@memberof`, `@class`, `@constructor`, `@type`, etc). Cons: - It is still in early stages (adoption is ongoing though, e.g. it is being used by the API extractor tool). - TSDoc != TypeDoc (the tool we currently use for generating our documentation). However, TypeDoc plans to officially support TSDoc in v1.1 (see TypeStrong/typedoc#1266). # Notable tag changes - `@ignore` is a JSDoc tag and was used in conjunction with `@internal`. These tags were needed because [TypeDoc does not yet support documenting only definitions exported by the entry point](TypeStrong/typedoc#1184 (comment)) and still documents everything exported from all files. I removed `@ignore` because [`@internal`](https://tsdoc.org/pages/tags/internal) only should suffice - `@ignore` when used alone is replaced with TypeDoc's [`hidden`](http://typedoc.org/guides/doccomments/#hidden-and-ignore). EDIT: I replaced `@ignore` with [`@hidden`](https://github.com/TypeStrong/typedoc/releases/tag/v0.12.0) because the TypeDoc version used for `docs.microsoft.com` is v0.15.0 which does not support `--stripInternal`. After, they upgrade, I will remove all `@hidden` tags. - `@summary` is gone because it is not part of TSDoc or TypeDoc This PR applies the changes to packages that respect our linting rules. Ones that do not yet will be migrated later when we start fixing their linting issues. Here are vanilla examples of TypeDoc 0.18.0 (version used by our EngSys) after the changes here as a sanity check: - random method:  - a class constructor that used to have type information in the documentation comments:  # `@hidden` works the same way as `@ignore` Here are the list of documented functions generated by `TypeDoc v0.15.0` for the text analytics package and there is no function that was marked `@hidden`, e.g. `combineSuccessfulAndErroneousDocumentsWithStatisticsAndModelVersion`  # Things to consider - Our documentation must be generated using the TypeDoc flag [`--stripInternal`](http://typedoc.org/guides/options/#stripinternal) - Should we add a `docs` npm script to our `package.json`s (similar to [Cosmos's](https://github.com/Azure/azure-sdk-for-js/blob/2424b74f029273677f62433f28dd1390806f682c/sdk/cosmosdb/cosmos/package.json#L60)) so that we can see how our docs are generated as we write our comments? Fixes #3027.
* add express sample * update README.md * update doc * update doc * add apiref * update curl sample * [event-hubs] express sample with sendBatch * remove duplicated eventProducer * update readme fix broken link * Update sdk/eventhub/event-hubs/samples/expressSample/src/index.ts Co-authored-by: chradek <[email protected]> * Update sdk/eventhub/event-hubs/samples/expressSample/src/README.md Co-authored-by: chradek <[email protected]> * Update sdk/eventhub/event-hubs/samples/expressSample/src/README.md Co-authored-by: chradek <[email protected]> * Update sdk/eventhub/event-hubs/samples/expressSample/src/README.md Co-authored-by: chradek <[email protected]> * Update sdk/eventhub/event-hubs/samples/expressSample/src/README.md Co-authored-by: chradek <[email protected]> * Update sdk/eventhub/event-hubs/samples/expressSample/src/README.md Co-authored-by: chradek <[email protected]> * Update sdk/eventhub/event-hubs/samples/expressSample/src/asyncBatchingProducer.ts Co-authored-by: chradek <[email protected]> * Update sdk/eventhub/event-hubs/samples/expressSample/src/index.ts Co-authored-by: chradek <[email protected]> * sample code batchSendSize=20 * renaming * remove metadata from readme Co-authored-by: chradek <[email protected]> Co-authored-by: chradek <[email protected]>
* Add PrepareRelease Script * Generalize Prepare-Release Script * Update Update-ChangeLog.ps1 * Update Package-Properties.ps1 * Update Collect-ChangeLog Script * Update Collect-ChangeLog.ps1 and Collect-Unreleased.ps1 * Update GeneralReleaseNotesParser.ps1 script * Update Prepare-Release Script to use recent DevOps Scripts * Move Get-LanguageName to eng\common\scripts\Helpers\DevOps-WorkItem-Helpers.ps1, improve error message, add logic to detect changes made by prepare-release script * Use LanguageDisplayName, move Get-CSVMetadata to Package-Properties.ps1 Co-authored-by: Chidozie Ononiwu <[email protected]>
* Replace only first azure- to generate package name
The base image now contains the same logic for installing Docker, so by the time our custom file ran Docker was already installed which causes Codespaces creation to error. This commit does a few things: 1. It restores our ability to use codespaces for development 2. It installs rush globally 3. It disables Oryx's default behavior for node since it conflicts with `rush`
This PR removes our dependency on the unmaintained package "karma-remap-istanbul" and replaces it with a smaller karma plugin ("karma-sourcemap-loader") that allows karma-coverage to load source maps from the disk correctly.
I tested and confirmed that the generated coverage data has the correct source TS files.
…th using token credential (#13271) * [phoneNumberAdminstrationClient] adding new constructor for phone number to use Token Credential * [Conflict] taking incoming recordings * [Recording] Update the query to be true * [README] update the examples and changelog * [phoneNumberAdministrationClientWithToken.spec] renmae the test to be more relevant * [recordedClient] using new common function to create endpoint * [recordedClient] removing unused COMMUNICATION_ENDPOINT * [tests.yml] adding the new env vars
* Add windows pool reference to cosmos ci matrix * Add windows pool reference to keyvault admin live test matrix
This is the initial version of Quantum Data Plane SDK. @ramya-rao-a Please review and approve @vxfield FYI....
…nable min-max tests (#12798)
* Modify the Configuration Markup Files * Regenerated Changes * Custom Code Changes * Test Code and API Changes * Updated Recordings Files * Update Test Code
* Increment package version after release of azure-synapse-monitoring * Increment package version after release of azure-synapse-managed-private-endpoints * Increment package version after release of azure-synapse-access-control * Increment package version after release of azure-synapse-spark * Increment package version after release of azure-synapse-artifacts
* Upgrade V6 SDK Generator Version for Tables * Hide the clients
* Lossen up $RELEASE_TITLE_REGEX to accomodate wrongly formated changelogs * Update changelog logic to use ordered hashtable * Update semver and Changelog logic Co-authored-by: Chidozie Ononiwu <[email protected]>
#13309 didn't catch this because core-crypto went in around the same time.
LuChen-Microsoft
merged commit 1264e7b
into
feature/communication-chat-2020-11-01-preview3
LuChen-Microsoft
added a commit
that referenced
this pull request
Jan 25, 2021
This reverts commit 1264e7b.
LuChen-Microsoft
added a commit
that referenced
this pull request
Jan 25, 2021
openapi-sdkautomation bot
pushed a commit
to AzureSDKAutomation/azure-sdk-for-js
that referenced
this pull request
Mar 9, 2021
20210304 depth rename compute (Azure#13337) * rename vmName * compatible-level: track2 * use alias
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.