-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Azure Quantum SDK for Azure SDK for JS #13345
Conversation
sdk/quantum/quantum/package.json
Outdated
"build": "tsc && rollup -c rollup.config.js && npm run minify && mkdirp ./review && npm run extract-api", | ||
"minify": "uglifyjs -c -m --comments --source-map \"content='./dist/quantum.js.map'\" -o ./dist/quantum.min.js ./dist/quantum.js", | ||
"prepack": "npm install && npm run build", | ||
"extract-api": "api-extractor run --local" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sarangan12, What is the reason that we don't have the same set of npm scripts as other packages? I would imagine that those would part of the scaffolding?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are the scripts that are autogenerated. Do you want to add anything more? Even for attestation, We have started with these initially and added more as needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, lets add the rest. The catch with keeping them empty is that we then have to remember to fill them up. I'd like to see how many of these we can get filled without issues from the initial commit so that we can set up that as a standard for future new packages
This pull request is protected by Check Enforcer. What is Check Enforcer?Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass. Why am I getting this message?You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged. What should I do now?If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows: What if I am onboarding a new service?Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment: |
eb3e622
to
fe346a0
Compare
sdk/quantum/quantum/package.json
Outdated
"minify": "uglifyjs -c -m --comments --source-map \"content='./dist/quantum.js.map'\" -o ./dist/quantum.min.js ./dist/quantum.js", | ||
"prepack": "npm install && npm run build", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't need minify
and prepack
scripts in Track 2 right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed them.
"tsconfig.json" | ||
], | ||
"scripts": { | ||
"build": "tsc && rollup -c rollup.config.js && mkdirp ./review && npm run extract-api", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once the review
directory is created in the initial commit, we don't have to recreate it every time the package is built right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The review directory will be created only if it doesn't exist.
"unit-test": "echo skip", | ||
"unit-test:browser": "echo skip", | ||
"unit-test:node": "echo skip", | ||
"docs": "echo skip" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any reason we cannot fill the above scripts like we have for other packages rather than keeping them as echo skip
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see that you answered in #13345 (comment), I have replied there as well :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The CI actually tries to run them and without actual tests they will fail. Also, we need to ensure each script runs before proceeding forward. Since this is a first commit, I made it to skip
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's do the rest of the npm scripts in a separate PR
Hello @ramya-rao-a! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
This is the initial version of Quantum Data Plane SDK.
@ramya-rao-a Please review and approve
@vxfield FYI....