Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Azure Quantum client for Azure SDK for JS #13322

Closed
wants to merge 2 commits into from
Closed

Azure Quantum client for Azure SDK for JS #13322

wants to merge 2 commits into from

Conversation

vxfield
Copy link
Member

@vxfield vxfield commented Jan 21, 2021

No description provided.

@vxfield vxfield requested a review from lmazuel January 21, 2021 16:26
deyaaeldeen
deyaaeldeen reviewed Jan 21, 2021
View reviewed changes
sdk/quantum/quantum-client/README.md

#### Sample code

Refer the sample code in the [azure-sdk-for-js-samples](https://github.com/Azure/azure-sdk-for-js-samples) repository.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this link is broken. Using the most recent code generator to regenerate should fix this problem. For example version: v6.0.0-dev.20210121.1.

deyaaeldeen
deyaaeldeen reviewed Jan 21, 2021
View reviewed changes
Copy link
Member

@deyaaeldeen deyaaeldeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add a package maintainer in .github/CODEOWNERS.

@ramya-rao-a
Copy link
Contributor

Hey @vxfield

Thanks for generating the package and creating the PR.

Unfortunately, there is a little bit of a scaffolding work around the generated code that we need to have in order to enable the build and release pipelines for this package. We will close this PR and create a new one with the required scaffolding and post a link here to the new PR.

We will be using the latest swagger file from https://github.com/Azure/azure-rest-api-specs/blob/master/specification/quantum/data-plane/Microsoft.Quantum/preview/2019-11-04-preview/quantum.json. Please let us know if we need to use an older version or a different file.

cc @sarangan12, @lmazuel

@vxfield
Copy link
Member Author

vxfield commented Jan 22, 2021 via email

@ramya-rao-a
Copy link
Contributor

Thanks for the confirmation @vxfield

You can follow the progress in #13345

@vxfield vxfield deleted the feature/azure-quantum-sdk branch January 25, 2021 18:29
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-js that referenced this pull request Jul 7, 2021
CodeGen from PR 13322 in Azure/azure-rest-api-specs
3c6c357 
[Stream Analytics] Add Subscription Level APIs (Azure#13322)

* add query testing apis

* add operationId and outputURI

* fix some linter errors

* fix model validation

* address some PR comments

* address some comments

* delete getoperationresults example

* try adding raw input datasource wrappers

* add inputs

* refactor input structure

* add outputs

* modify some descriptions

* address more comments

* add 200 response

* fix formatting

* Delete package-lock.json

* restore package-lock.json

* address final comments

* add compile query

* add sample input api

* add test input and test output apis

* fix validation errors

* update testQuery and compileQuery

* update sample input and test input/output

* final fixes

* fix linter errors pt1

* fix small bugs

* remove duplicate operations def

Co-authored-by: Roslyn Lu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deyaaeldeen deyaaeldeen deyaaeldeen left review comments

@lmazuel lmazuel Awaiting requested review from lmazuel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vxfield @ramya-rao-a @deyaaeldeen