Upgrade V6 SDK Generator Version for Text Analytics #13359
Conversation
ghost
added
the
| @@ -229,6 +229,44 @@ export interface KeyPhrasesTask { | |||
| modelVersion?: string; | |||
| } | |||
|
|
|||
| // @public | |||
| export const enum KnownInnerErrorCodeValue { | |||
| // (undocumented) | |||
There was a problem hiding this comment.
This (undocumented) is part of the generated code that comes from the swagger. And Adding documentation for enum values does not make much sense. So, I think this is acceptable.
There was a problem hiding this comment.
Thanks @sarangan12! I wonder why this enum is not generated as a union of string as before but without unioning with string of course?
There was a problem hiding this comment.
This is the new method. For any extensible enums we define it simply as a string and take the allowed values and put it enum just as above. We export both the values
| @@ -229,6 +229,44 @@ export interface KeyPhrasesTask { | |||
| modelVersion?: string; | |||
| } | |||
|
|
|||
| // @public | |||
| export const enum KnownInnerErrorCodeValue { | |||
| // (undocumented) | |||
There was a problem hiding this comment.
Thanks @sarangan12! I wonder why this enum is not generated as a union of string as before but without unioning with string of course?
| @@ -37,6 +37,7 @@ import { | |||
| GeneratedClientSentimentResponse | |||
| } from "./models"; | |||
|
|
|||
| /** @hidden */ | |||
There was a problem hiding this comment.
I think it would be better to replace @hidden with @internal here because we want to reserve @hidden for definitions that are supposed to be exported to the user but we still do not want them showing up in the docs. I can make this change later in the code generator after I replace all @hidden tags in the SDK repo first.
There was a problem hiding this comment.
Noted. I will fix it today.
|
/azp run js - textanalytics - tests |
|
No pipelines are associated with this pull request. |
|
/azp run js - ai-text-analytics - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Merge Dev-containerservice-microsoft.containerservice-2021-03-01 API to master (Azure#13737) * Adds base for updating Microsoft.ContainerService from version stable/2021-02-01 to version 2021-03-01 * Updates readme * Updates API version in new specs and examples * fix the top swagger offenses caused by privateLinkResources, enableCSIProxy and OSDiskSize range (Azure#13349) Co-authored-by: Charlie Li <[email protected]> * Add enableFIPS property to 2021-03-01 API in dev 2021-03-01 branch (Azure#13359) * fix the top swagger offenses caused by privateLinkResources, enableCSIProxy and OSDiskSize range * Add enableFIPS property to the 2021-03-01 API * Add enableFIPS property to the 2021-03-01 API Co-authored-by: Charlie Li <[email protected]> * adding node-image upgrade channel enum (Azure#13375) Co-authored-by: Charlie McBride <[email protected]> * Add httpProxyConfig specs to 2021-03-01 API - dev (Azure#13410) * Add httpProxyConfig specs to 2021-03-01 API - dev * Fix prettier * aks: add `bindingSelector` to managed cluster pod identity profile (Azure#13399) * AKS runCommand new feature (Azure#13420) * runCommand target to 03-01 * fix api-version in examples * Add property disableLocalAccounts to 2021-03-01 API version (Azure#13385) * Add property disableLocalAccounts * Fix indentation * Add OSSKU and GPUInstanceProfile to containerservice/microsoft.container API 2021-03-01 (Azure#13532) * Add OSSKU and GPUInstanceProfile * Add sample for OSSKU and GPUInstanceProfile * Fix custom words * Reference sample files * update custom-words * Update readme for sdks (Azure#13515) * update readme for sdks * update readme for sdks Co-authored-by: Charlie Li <[email protected]> * Add example to create agent pool with FIPS enabled (Azure#13557) * add example to create agent pool with FIPS enabled * change a property name in the example file Co-authored-by: Charlie Li <[email protected]> * Added extended location parameter to managed cluster which will target all agent pools to that extended location. (Azure#13560) * Add data model for get OS options. (Azure#13619) * Add data model for get OS options. * Add default resource name in API path. * Fix container service tags. (Azure#13739) Co-authored-by: Tongyao Si <[email protected]> Co-authored-by: Charlie Li <[email protected]> Co-authored-by: Charlie McBride <[email protected]> Co-authored-by: Charlie McBride <[email protected]> Co-authored-by: Bo Wang <[email protected]> Co-authored-by: hbc <[email protected]> Co-authored-by: Haitao Chen <[email protected]> Co-authored-by: Tony Xu <[email protected]> Co-authored-by: Mirza Sikander <[email protected]> Co-authored-by: Jun Sun <[email protected]>
The last V6 SDK version that is used to generate Text Analytics is
6.0.0-dev.20201027.1. This PR is to upgrade the V6 SDK version to the latest6.0.0-dev.20210121.2version.@deyaaeldeen @witemple-msft Please review and approve.
@joheredi @ramya-rao-a FYI.......