Add check for valid API review directory #13375
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
praveenkuttappan
requested review from
danieljurek,
mitchdenny and
weshaggard
as code owners
weshaggard
reviewed
Jan 25, 2021
| @@ -210,6 +210,11 @@ function Find-javascript-Artifacts-For-Apireview($artifactDir, $packageName = "" | |||
| [regex]$pattern = "azure-" | |||
| $pkgName = $pattern.replace($packageName, "", 1) | |||
| $packageDir = Join-Path $artifactDir $pkgName "temp" | |||
| if (-not (Test-Path $packageDir)) | |||
There was a problem hiding this comment.
Who are we expecting to create this temp directory?
There was a problem hiding this comment.
This is created by api-extractor if docmodel is enabled.
There was a problem hiding this comment.
It might be better to move this error check closer to where we expect it to be created, as if this step fails it isn't clear how someone would go and fix it.
There was a problem hiding this comment.
This is actually within the api-extractor tool itself. I have added the log with info on how to enable api-extractor json output file. I am going to put this change on hold until I get a confirmation from JS team whether they plan to skip API-extract step for few packages or not.
weshaggard
approved these changes
Jan 28, 2021
|
This change is not required as per discussion with Ramya. We will enable doc model for all packages. |
openapi-sdkautomation bot
pushed a commit
to AzureSDKAutomation/azure-sdk-for-js
that referenced
this pull request
Apr 1, 2021
Merge Dev-containerservice-microsoft.containerservice-2021-03-01 API to master (Azure#13737) * Adds base for updating Microsoft.ContainerService from version stable/2021-02-01 to version 2021-03-01 * Updates readme * Updates API version in new specs and examples * fix the top swagger offenses caused by privateLinkResources, enableCSIProxy and OSDiskSize range (Azure#13349) Co-authored-by: Charlie Li <[email protected]> * Add enableFIPS property to 2021-03-01 API in dev 2021-03-01 branch (Azure#13359) * fix the top swagger offenses caused by privateLinkResources, enableCSIProxy and OSDiskSize range * Add enableFIPS property to the 2021-03-01 API * Add enableFIPS property to the 2021-03-01 API Co-authored-by: Charlie Li <[email protected]> * adding node-image upgrade channel enum (Azure#13375) Co-authored-by: Charlie McBride <[email protected]> * Add httpProxyConfig specs to 2021-03-01 API - dev (Azure#13410) * Add httpProxyConfig specs to 2021-03-01 API - dev * Fix prettier * aks: add `bindingSelector` to managed cluster pod identity profile (Azure#13399) * AKS runCommand new feature (Azure#13420) * runCommand target to 03-01 * fix api-version in examples * Add property disableLocalAccounts to 2021-03-01 API version (Azure#13385) * Add property disableLocalAccounts * Fix indentation * Add OSSKU and GPUInstanceProfile to containerservice/microsoft.container API 2021-03-01 (Azure#13532) * Add OSSKU and GPUInstanceProfile * Add sample for OSSKU and GPUInstanceProfile * Fix custom words * Reference sample files * update custom-words * Update readme for sdks (Azure#13515) * update readme for sdks * update readme for sdks Co-authored-by: Charlie Li <[email protected]> * Add example to create agent pool with FIPS enabled (Azure#13557) * add example to create agent pool with FIPS enabled * change a property name in the example file Co-authored-by: Charlie Li <[email protected]> * Added extended location parameter to managed cluster which will target all agent pools to that extended location. (Azure#13560) * Add data model for get OS options. (Azure#13619) * Add data model for get OS options. * Add default resource name in API path. * Fix container service tags. (Azure#13739) Co-authored-by: Tongyao Si <[email protected]> Co-authored-by: Charlie Li <[email protected]> Co-authored-by: Charlie McBride <[email protected]> Co-authored-by: Charlie McBride <[email protected]> Co-authored-by: Bo Wang <[email protected]> Co-authored-by: hbc <[email protected]> Co-authored-by: Haitao Chen <[email protected]> Co-authored-by: Tony Xu <[email protected]> Co-authored-by: Mirza Sikander <[email protected]> Co-authored-by: Jun Sun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Verify if temp directory is present before searching for json file.