Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[identity] Warnings when building identity package in rush #13557

Closed
xirzec opened this issue Feb 3, 2021 · 3 comments
Closed

[identity] Warnings when building identity package in rush #13557

xirzec opened this issue Feb 3, 2021 · 3 comments
Assignees
@sadasant
Labels
Azure.Identity Client This issue points to a problem in the data-plane of the library.
Milestone
[2021] July

Comments

@xirzec
Copy link
Member

xirzec commented Feb 3, 2021

There are a lot of warnings in our build from msal-node. This doesn't feel very good and we should do something to resolve this.

Warning: C:/src/azure-sdk-for-js/common/temp/node_modules/.pnpm/@azure/[email protected]/node_modules/@azure/msal-node/dist/index.d.ts:10:8 - (TS2304) Cannot find name 'type'.
Warning: C:/src/azure-sdk-for-js/common/temp/node_modules/.pnpm/@azure/[email protected]/node_modules/@azure/msal-node/dist/index.d.ts:10:15 - (TS2304) Cannot find name 'AuthorizationCodeRequest'.
Warning: C:/src/azure-sdk-for-js/common/temp/node_modules/.pnpm/@azure/[email protected]/node_modules/@azure/msal-node/dist/index.d.ts:10:42 - (TS2304) Cannot find name 'from'.
Warning: C:/src/azure-sdk-for-js/common/temp/node_modules/.pnpm/@azure/[email protected]/node_modules/@azure/msal-node/dist/index.d.ts:11:8 - (TS2304) Cannot find name 'type'.
Warning: C:/src/azure-sdk-for-js/common/temp/node_modules/.pnpm/@azure/[email protected]/node_modules/@azure/msal-node/dist/index.d.ts:11:15 - (TS2304) Cannot find name 'AuthorizationUrlRequest'.
Warning: C:/src/azure-sdk-for-js/common/temp/node_modules/.pnpm/@azure/[email protected]/node_modules/@azure/msal-node/dist/index.d.ts:11:41 - (TS2304) Cannot find name 'from'.
Warning: C:/src/azure-sdk-for-js/common/temp/node_modules/.pnpm/@azure/[email protected]/node_modules/@azure/msal-node/dist/index.d.ts:12:8 - (TS2304) Cannot find name 'type'.
Warning: C:/src/azure-sdk-for-js/common/temp/node_modules/.pnpm/@azure/[email protected]/node_modules/@azure/msal-node/dist/index.d.ts:12:15 - (TS2304) Cannot find name 'ClientCredentialRequest'.
Warning: C:/src/azure-sdk-for-js/common/temp/node_modules/.pnpm/@azure/[email protected]/node_modules/@azure/msal-node/dist/index.d.ts:12:41 - (TS2304) Cannot find name 'from'.
Warning: C:/src/azure-sdk-for-js/common/temp/node_modules/.pnpm/@azure/[email protected]/node_modules/@azure/msal-node/dist/index.d.ts:13:8 - (TS2304) Cannot find name 'type'.
Warning: C:/src/azure-sdk-for-js/common/temp/node_modules/.pnpm/@azure/[email protected]/node_modules/@azure/msal-node/dist/index.d.ts:13:15 - (TS2304) Cannot find name 'DeviceCodeRequest'.
Warning: C:/src/azure-sdk-for-js/common/temp/node_modules/.pnpm/@azure/[email protected]/node_modules/@azure/msal-node/dist/index.d.ts:13:35 - (TS2304) Cannot find name 'from'.
Warning: C:/src/azure-sdk-for-js/common/temp/node_modules/.pnpm/@azure/[email protected]/node_modules/@azure/msal-node/dist/index.d.ts:14:8 - (TS2304) Cannot find name 'type'.
Warning: C:/src/azure-sdk-for-js/common/temp/node_modules/.pnpm/@azure/[email protected]/node_modules/@azure/msal-node/dist/index.d.ts:14:15 - (TS2304) Cannot find name 'OnBehalfOfRequest'.
Warning: C:/src/azure-sdk-for-js/common/temp/node_modules/.pnpm/@azure/[email protected]/node_modules/@azure/msal-node/dist/index.d.ts:14:35 - (TS2304) Cannot find name 'from'.
Warning: C:/src/azure-sdk-for-js/common/temp/node_modules/.pnpm/@azure/[email protected]/node_modules/@azure/msal-node/dist/index.d.ts:15:8 - (TS2304) Cannot find name 'type'.
Warning: C:/src/azure-sdk-for-js/common/temp/node_modules/.pnpm/@azure/[email protected]/node_modules/@azure/msal-node/dist/index.d.ts:15:15 - (TS2304) Cannot find name 'RefreshTokenRequest'.
Warning: C:/src/azure-sdk-for-js/common/temp/node_modules/.pnpm/@azure/[email protected]/node_modules/@azure/msal-node/dist/index.d.ts:15:37 - (TS2304) Cannot find name 'from'.
Warning: C:/src/azure-sdk-for-js/common/temp/node_modules/.pnpm/@azure/[email protected]/node_modules/@azure/msal-node/dist/index.d.ts:16:8 - (TS2304) Cannot find name 'type'.
Warning: C:/src/azure-sdk-for-js/common/temp/node_modules/.pnpm/@azure/[email protected]/node_modules/@azure/msal-node/dist/index.d.ts:16:15 - (TS2304) Cannot find name 'SilentFlowRequest'.
Warning: C:/src/azure-sdk-for-js/common/temp/node_modules/.pnpm/@azure/[email protected]/node_modules/@azure/msal-node/dist/index.d.ts:16:35 - (TS2304) Cannot find name 'from'.
Warning: types/src/client/msalClient.d.ts:2:10 - (TS2305) Module '"../../../../../../common/temp/node_modules/.pnpm/@azure/[email protected]/node_modules/@azure/msal-node/dist"' has no exported member 'AuthorizationCodeRequest'.
Warning: types/src/client/msalClient.d.ts:2:58 - (TS2305) Module '"../../../../../../common/temp/node_modules/.pnpm/@azure/[email protected]/node_modules/@azure/msal-node/dist"' has no exported member 'DeviceCodeRequest'.
Warning: types/src/client/msalClient.d.ts:2:77 - (TS2305) Module '"../../../../../../common/temp/node_modules/.pnpm/@azure/[email protected]/node_modules/@azure/msal-node/dist"' has no exported member 'ClientCredentialRequest'.
@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Feb 3, 2021
@ramya-rao-a ramya-rao-a added Azure.Identity Client This issue points to a problem in the data-plane of the library. labels Feb 3, 2021
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Feb 3, 2021
@ramya-rao-a ramya-rao-a added this to the [2021] March milestone Feb 3, 2021
@sadasant
Copy link
Contributor

sadasant commented Feb 3, 2021

I'll copy here something that Deya said in another channel, just to have it for when I have time to work on this:

[1:58 PM] Deyaaeldeen Almahallawi
The support for this import syntax came in v7.9.0 and we currently use v7.7.11. See microsoft/rushstack#1985 (comment). I believe we did not want to do the upgrade because it will cause issues related to conflicts in naming between some of our exported definitions and TS standard lib definitions. A simpler solution is to not use that import syntax for now.

@sadasant sadasant modified the milestones: [2021] March, [2021] April Feb 10, 2021
@sadasant sadasant modified the milestones: [2021] April, [2021] May Mar 15, 2021
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-js that referenced this issue Apr 1, 2021
@norshtein @charlili1234
@charliedmcb @bowang-666 @bcho @haitch @MirzaSikander @JunSun17
CodeGen from PR 13737 in Azure/azure-rest-api-specs
178a293 
Merge Dev-containerservice-microsoft.containerservice-2021-03-01 API to master  (Azure#13737)

* Adds base for updating Microsoft.ContainerService from version stable/2021-02-01 to version 2021-03-01

* Updates readme

* Updates API version in new specs and examples

* fix the top swagger offenses caused by privateLinkResources, enableCSIProxy and OSDiskSize range (Azure#13349)

Co-authored-by: Charlie Li <[email protected]>

* Add enableFIPS property to 2021-03-01 API in dev 2021-03-01 branch (Azure#13359)

* fix the top swagger offenses caused by privateLinkResources, enableCSIProxy and OSDiskSize range

* Add enableFIPS property to the 2021-03-01 API

* Add enableFIPS property to the 2021-03-01 API

Co-authored-by: Charlie Li <[email protected]>

* adding node-image upgrade channel enum (Azure#13375)

Co-authored-by: Charlie McBride <[email protected]>

* Add httpProxyConfig specs to 2021-03-01 API - dev (Azure#13410)

* Add httpProxyConfig specs to 2021-03-01 API - dev

* Fix prettier

* aks: add `bindingSelector` to managed cluster pod identity profile (Azure#13399)

* AKS runCommand new feature  (Azure#13420)

* runCommand target to 03-01

* fix api-version in examples

* Add property disableLocalAccounts to 2021-03-01 API version (Azure#13385)

* Add property disableLocalAccounts

* Fix indentation

* Add OSSKU and GPUInstanceProfile to containerservice/microsoft.container API 2021-03-01 (Azure#13532)

* Add OSSKU and GPUInstanceProfile

* Add sample for OSSKU and GPUInstanceProfile

* Fix custom words

* Reference sample files

* update custom-words

* Update readme for sdks  (Azure#13515)

* update readme for sdks

* update readme for sdks

Co-authored-by: Charlie Li <[email protected]>

* Add example to create agent pool with FIPS enabled (Azure#13557)

* add example to create agent pool with FIPS enabled

* change a property name in the example file

Co-authored-by: Charlie Li <[email protected]>

* Added extended location parameter to managed cluster which will target all agent pools to that extended location. (Azure#13560)

* Add data model for get OS options. (Azure#13619)

* Add data model for get OS options.

* Add default resource name in API path.

* Fix container service tags. (Azure#13739)

Co-authored-by: Tongyao Si <[email protected]>
Co-authored-by: Charlie Li <[email protected]>
Co-authored-by: Charlie McBride <[email protected]>
Co-authored-by: Charlie McBride <[email protected]>
Co-authored-by: Bo Wang <[email protected]>
Co-authored-by: hbc <[email protected]>
Co-authored-by: Haitao Chen <[email protected]>
Co-authored-by: Tony Xu <[email protected]>
Co-authored-by: Mirza Sikander <[email protected]>
Co-authored-by: Jun Sun <[email protected]>
@sadasant sadasant modified the milestones: [2021] May, [2021] June Apr 12, 2021
@sadasant
Copy link
Contributor

Pushed to June since time is running out and we'll likely not have budget for this.

@sadasant sadasant modified the milestones: [2021] June, [2021] July May 11, 2021
@sadasant
Copy link
Contributor

This issue Will be solved by #9410 , so I'll close it!

@maorleger maorleger mentioned this issue Sep 2, 2021
Closed
@maorleger maorleger mentioned this issue Sep 20, 2021
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sadasant sadasant

Labels
Azure.Identity Client This issue points to a problem in the data-plane of the library.
Projects
None yet
Milestone
[2021] July
Development

No branches or pull requests
3 participants
@sadasant @xirzec @ramya-rao-a