Upgrade V6 SDK Generator Version for Form Recognizer #13360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarangan12
requested review from
bterlson,
chradek,
jeremymeng,
witemple-msft and
xirzec
as code owners
ghost
added
the
sarangan12
commented
Jan 23, 2021
|
|
||
| // @public | ||
| export type Language = "en" | "es" | "de" | "fr" | "it" | "nl" | "pt" | "zh-Hans" | string; | ||
| export const enum KnownKeyValueType { | ||
| // (undocumented) |
There was a problem hiding this comment.
This (undocumented) is part of the generated code that comes from the swagger. And Adding documentation for enum values does not make much sense. So, I think this is acceptable.
|
/azp run js - ai-form-recognizer - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
witemple-msft
approved these changes
Jan 25, 2021
There was a problem hiding this comment.
Seems reasonable to me. It would be nice if we could have documentation on the enum variants, even a simple automatically generated one, but I agree that it's not that big of a deal as long as the enum itself has documentation.
I do wonder about the discoverability of the KnownKeyValueType enum (and its friends). At the least, I'm going to create an issue to add usage of these enums to samples for the next preview.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The last V6 SDK version that is used to generate Form Recognizer is
6.0.0-dev.20201113.1. This PR is to upgrade the V6 SDK version to the latest6.0.0-dev.20210121.2version.@jeremymeng Please review and approve.
@joheredi @ramya-rao-a FYI.......