Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix codespaces deployment #13338

Merged
merged 3 commits into from
Jan 22, 2021
Merged

Fix codespaces deployment #13338

merged 3 commits into from
Jan 22, 2021

Conversation

maorleger
Copy link
Member

@maorleger maorleger commented Jan 22, 2021 •
edited
Loading

The base image now contains the same logic
for installing Dockerfile, so by the time our custom file
ran Docker was already installed which causes Codespaces
creation to error.

This commit does a few things:

  1. It restores our ability to use codespaces for development
  2. It installs rush globally
  3. It disables Oryx's default behavior for node since it conflicts with rush

@maorleger maorleger changed the title Remove custom codespace Dockerfile Fix codespaces deployment Jan 22, 2021
@maorleger maorleger requested a review from mitchdenny January 22, 2021 05:38
deyaaeldeen
deyaaeldeen approved these changes Jan 22, 2021
View reviewed changes
Copy link
Member

@deyaaeldeen deyaaeldeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

chradek
chradek approved these changes Jan 22, 2021
View reviewed changes
Copy link
Contributor

@chradek chradek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting this together @maorleger! Looks great!

@maorleger maorleger merged commit b194f0d into Azure:master Jan 22, 2021
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-js that referenced this pull request Mar 10, 2021
CodeGen from PR 13338 in Azure/azure-rest-api-specs
99dd8d2 
20210304 depth rename network (Azure#13338)

* readme.az.md

* indent

* hide all

* param-name

* use alias
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chradek chradek chradek approved these changes

@deyaaeldeen deyaaeldeen deyaaeldeen approved these changes

@richardpark-msft richardpark-msft Awaiting requested review from richardpark-msft

@mitchdenny mitchdenny Awaiting requested review from mitchdenny

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maorleger @deyaaeldeen @chradek