Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core-crypto] Remove karma-remap-istanbul dependency #13378

Merged
1 commit merged into from
Jan 25, 2021

Conversation

xirzec
Copy link
Member

@xirzec xirzec commented Jan 25, 2021

#13309 didn't catch this because core-crypto went in around the same time.

@xirzec xirzec added Client This issue points to a problem in the data-plane of the library. Azure.Core labels Jan 25, 2021
@xirzec xirzec requested a review from chradek January 25, 2021 19:50
@xirzec xirzec self-assigned this Jan 25, 2021
@@ -44,6 +44,10 @@
"name": "core-client",
"path": "sdk/core/core-client"
},
{
"name": "core-crypto",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woops, thank you!

@ghost
Copy link

ghost commented Jan 25, 2021

Hello @xirzec!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit 1d2d65f into Azure:master Jan 25, 2021
@xirzec xirzec deleted the updateKarma3 branch January 25, 2021 22:12
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-js that referenced this pull request Mar 12, 2021
[Hub Generated] Review request for Microsoft.Consumption to add version stable/2019-10-01 (Azure#13378)

* Added swagger updates for the optional forecastSpend JSON field in Budget API

* Review feedback

* Internal review update
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure.Core Client This issue points to a problem in the data-plane of the library.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants