Upgrade V6 SDK Generator Version for Tables #13362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarangan12
requested review from
bterlson,
chradek,
joheredi and
xirzec
as code owners
ghost
added
the
sarangan12
commented
Jan 23, 2021
| @@ -354,15 +364,6 @@ export interface TableCreateHeaders { | |||
| version?: string; | |||
| } | |||
|
|
|||
| // @public | |||
| export interface TableCreateHeaders { | |||
There was a problem hiding this comment.
This is not a deletion. The TableCreateHeaders was defined twice earlier. Now, one of it is removed.
sarangan12
commented
Jan 23, 2021
| @@ -426,17 +427,6 @@ export interface TableInsertEntityHeaders { | |||
| version?: string; | |||
| } | |||
|
|
|||
| // @public | |||
| export interface TableInsertEntityHeaders { | |||
There was a problem hiding this comment.
This is not a deletion. The TableInsertEntityHeaders was defined twice earlier. Now, one of it is removed.
sarangan12
commented
Jan 23, 2021
| * Class representing a Service. | ||
| */ | ||
| /** Class representing a Service. */ | ||
| /** @hidden */ |
There was a problem hiding this comment.
This is manually added for this PR. I will do the Generator Code change soon.
There was a problem hiding this comment.
Can you please add a comment that this is manually added and link the issue tracking the generator changes? Unless you plan to merge this after the generator changes are merged
There was a problem hiding this comment.
Here is the issue - Azure/autorest.typescript#849. Will send in the fix today.
joheredi
approved these changes
Jan 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The last V6 SDK version that is used to generate Tables is 6.0.0-dev.20200817.1. This PR is to upgrade the V6 SDK version to the latest 6.0.0-dev.20210121.2 version.
@joheredi Please review and approve.
@ramya-rao-a FYI.......