Add LinuxMint support for install.sh #3281
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Traffic volume is reduced 21 times (!) * As expected, only small messages appear in clear text (uncompressed) now in tcpdump(1) output. Messages smaller than 1024 bytes are not compressed * Compression is used according to the following: server perMessageDeflate=true, client perMessageDeflate=true: yes server perMessageDeflate=true, client perMessageDeflate not set: yes server perMessageDeflate not set, client perMessageDeflate=true: no server perMessageDeflate not set, client perMessageDeflate not set: no
…d remove obsolete ones (ArkEcosystem#2895)
…ArkEcosystem#2904) The previous code would remove entires from milestoneHeights[] even if no milestone is hit (due to e.g. "currentTransactionsCount >= 150" being true).
…cosystem#2910) Use `SELECT COALESCE(MAX(nonce), 0)` instead of `SELECT COUNT(*)` - they produce the same result, but the former is much faster. With this change a full block insert (with 500 transactions, so 1 + 500 INSERT queries) drops from about 4 seconds to about 0.4 seconds - the same time it takes without the check constraint and the trigger on the transactions table.
…ystem#2903) * Print the reason for discarding a block When processing blocks, if we find that some block is not chained then we abandon the rest of the blocks. In this case, print a detailed message explaining that a block is not chained and why. Without this printout sync failures could be very obscure and difficult to analyze. * Reset last downloaded block if we get an unchained block This would make us try to download the block at the same height again from a different peer. Also, check if the block being tested for isBlockChained() is in the list of exceptions and if so, assume the check has passed.
…Ecosystem#2917) * test: add e2e tests for invalid multisig txs * test: e2e for htlc lock/claim with multisig wallet * test: e2e lock/refund with multisig wallet * test: e2e multisig htlc test refactor
…t manager findByIndex() when no "local" match (ArkEcosystem#3256) * fix: wallet-manager findByIndex try find index with db wallet manager if no match "locally" * test: wallet-manager findByIndex
Co-authored-by: Renovate Bot <[email protected]>
deanpress
requested review from
air1one,
faustbrian,
kristjank and
spkjp
as code owners
|
Thanks for submitting this pull request! A maintainer will review this in the next few days and explicitly select labels so you know what's going on. If no reviewer appears after a week, a reminder will be sent out. |
|
closed for #3282 |
|
Your pull request has been closed, thank you for trying to solve an issue. If you think it was closed prematurely please provide additional information. |
|
This pull request introduces 1 alert and fixes 14 when merging 0a73723 into ce0df36 - view on LGTM.com new alerts:
fixed alerts:
|
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Linux Mint had issues with the nodesource package source being added in
install.sh. This fixes it.Checklist