Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): remove password flag constraint for core:forger command #3270

Merged
merged 1 commit into from
Nov 19, 2019

Conversation

faustbrian
Copy link
Contributor

Summary

Removes the bip38 constraint from the --password flag so that it can be used as documented on docs.ark.io. This makes it possible to run the core:forger command directly instead of the underlying commands.

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@codecov
Copy link

codecov bot commented Nov 18, 2019

Codecov Report

Merging #3270 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           develop   #3270   +/-   ##
=======================================
  Coverage     65.2%   65.2%           
=======================================
  Files          431     431           
  Lines        12132   12132           
  Branches      1633    1633           
=======================================
  Hits          7911    7911           
  Misses        4188    4188           
  Partials        33      33
Impacted Files Coverage Δ
packages/core/src/commands/command.ts 0% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 800bc8e...8e9ef9a. Read the comment docs.

@faustbrian faustbrian merged commit 5aea54f into develop Nov 19, 2019
@ghost ghost deleted the fix/forger-flags branch November 19, 2019 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants