Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core-forger): don't swallow BIP38 errors #3271

Merged
merged 2 commits into from
Nov 19, 2019
Merged

Conversation

faustbrian
Copy link
Contributor

Summary

If anything with the provided bip38 or password was wrong it was just assumed that no delegate will be used. Now the exception will be thrown and nothing is assumed.

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@codecov
Copy link

codecov bot commented Nov 18, 2019

Codecov Report

Merging #3271 into develop will decrease coverage by 35.64%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##           develop    #3271       +/-   ##
============================================
- Coverage     65.2%   29.55%   -35.65%     
============================================
  Files          431      431               
  Lines        12129    12125        -4     
  Branches      1633     1633               
============================================
- Hits          7909     3584     -4325     
- Misses        4187     8515     +4328     
+ Partials        33       26        -7
Impacted Files Coverage Δ
packages/core-forger/src/delegate.ts 41.07% <0%> (-58.93%) ⬇️
packages/core-utils/src/has-some-property.ts 0% <0%> (-100%) ⬇️
...ckages/core-jest-matchers/src/fields/public-key.ts 0% <0%> (-100%) ⬇️
.../core-jest-matchers/src/transactions/types/ipfs.ts 0% <0%> (-100%) ⬇️
...ackages/core-blockchain/src/machines/blockchain.ts 0% <0%> (-100%) ⬇️
...ypto/src/transactions/utils/bridgechain-schemas.ts 0% <0%> (-100%) ⬇️
packages/core-utils/src/capped-set.ts 0% <0%> (-100%) ⬇️
.../core-jest-matchers/src/transactions/types/vote.ts 0% <0%> (-100%) ⬇️
packages/core-utils/src/nsect.ts 0% <0%> (-100%) ⬇️
...n/src/processor/handlers/already-forged-handler.ts 0% <0%> (-100%) ⬇️
... and 193 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12869b3...ad0e3a7. Read the comment docs.

@faustbrian faustbrian merged commit f3dcb1f into develop Nov 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants