Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: AIP103 #2892

Merged
merged 45 commits into from
Aug 28, 2019
Merged

refactor: AIP103 #2892

merged 45 commits into from
Aug 28, 2019

Conversation

spkjp
Copy link
Contributor

@spkjp spkjp commented Aug 27, 2019

Refactors #2858 and fixes a few bugs.

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactor
  • Performance
  • Tests
  • Build
  • Documentation
  • Code style update
  • Continuous Integration
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Does this PR release a new version?

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • It's submitted to the develop branch, not the master branch
  • All tests are passing
  • New/updated tests are included

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

@codecov-io
Copy link

codecov-io commented Aug 27, 2019

Codecov Report

Merging #2892 into develop will increase coverage by 0.19%.
The diff coverage is 68.6%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2892      +/-   ##
===========================================
+ Coverage    67.66%   67.86%   +0.19%     
===========================================
  Files          405      405              
  Lines         9740     9725      -15     
  Branches       492      501       +9     
===========================================
+ Hits          6591     6600       +9     
+ Misses        3111     3086      -25     
- Partials        38       39       +1
Impacted Files Coverage Δ
...core-transactions/src/handlers/handler-registry.ts 95.08% <ø> (ø) ⬆️
...database-postgres/src/repositories/transactions.ts 26.53% <0%> (-0.56%) ⬇️
...c/repositories/transactions-business-repository.ts 90.9% <0%> (ø) ⬆️
...e-marketplace/src/handlers/business-resignation.ts 58.06% <0%> (+3.51%) ⬆️
...ages/core-transactions/src/handlers/htlc-refund.ts 70.32% <0%> (-1.1%) ⬇️
...es/core-blockchain/src/replay/replay-blockchain.ts 0% <0%> (ø) ⬆️
...kages/core-transactions/src/handlers/htlc-claim.ts 72% <0%> (-1%) ⬇️
packages/core-marketplace/src/wallet-manager.ts 100% <100%> (ø) ⬆️
...place/src/transactions/bridgechain-registration.ts 100% <100%> (ø) ⬆️
...e-marketplace/src/builders/business-resignation.ts 100% <100%> (ø) ⬆️
... and 31 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0f4fbf...1888caf. Read the comment docs.

@faustbrian faustbrian merged commit 3f645e0 into develop Aug 28, 2019
@ghost ghost deleted the refactor/aip103 branch August 28, 2019 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants