Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core-magistrate): use wallet publicKey for business id index #3268

Merged
merged 3 commits into from
Nov 19, 2019

Conversation

air1one
Copy link
Contributor

@air1one air1one commented Nov 18, 2019

Summary

Resolves #3259

Use wallet publicKey for business id index, as a business is unique to a wallet.

Before we were using a wallet manager based index which can lead to bugs (database wallet manager does not hold the same state as tx pool wallet manager, so we can easily choose a wrong id).

Checklist

  • Documentation (if necessary)
  • Tests (if necessary)
  • Ready to be merged

@codecov
Copy link

codecov bot commented Nov 18, 2019

Codecov Report

Merging #3268 into develop will increase coverage by 0.24%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #3268      +/-   ##
===========================================
+ Coverage     65.2%   65.44%   +0.24%     
===========================================
  Files          431      431              
  Lines        12129    12127       -2     
  Branches      1633     1633              
===========================================
+ Hits          7909     7937      +28     
+ Misses        4187     4157      -30     
  Partials        33       33
Impacted Files Coverage Δ
...kages/core-api/src/handlers/wallets/transformer.ts 81.81% <ø> (ø) ⬆️
...kages/core-api/src/handlers/bridgechains/schema.ts 100% <ø> (ø) ⬆️
...se/src/repositories/wallets-business-repository.ts 64.04% <ø> (+0.71%) ⬆️
...ackages/core-api/src/handlers/businesses/schema.ts 100% <ø> (ø) ⬆️
...transactions/src/handlers/business-registration.ts 61.11% <ø> (-1.06%) ⬇️
...ckages/core-api/src/handlers/businesses/methods.ts 93.1% <100%> (+51.72%) ⬆️
...core-magistrate-transactions/src/wallet-manager.ts 100% <100%> (ø) ⬆️
...es/core-api/src/handlers/businesses/transformer.ts 100% <0%> (+50%) ⬆️
.../core-api/src/handlers/bridgechains/transformer.ts 100% <0%> (+50%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12869b3...6b03743. Read the comment docs.

@faustbrian faustbrian merged commit 3416b86 into develop Nov 19, 2019
@ghost ghost deleted the fix/core-magistrate/businessId branch November 19, 2019 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants