Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core-magistrate: refactor business id #3259

Closed
air1one opened this issue Nov 15, 2019 · 0 comments
Closed

core-magistrate: refactor business id #3259

air1one opened this issue Nov 15, 2019 · 0 comments

Comments

@air1one
Copy link
Contributor

air1one commented Nov 15, 2019

Related to #3257 and #3258

Current business id logic is just an increment based on current businesses registered on wallet manager.
As we've seen with bridgechain id, it can be bug-prone (see PR #3258).

So in my opinion we should decide on another id logic for business id. (for example use a hash from name+website ?)

Would like to have some opinions, thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants