Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add <ReadMore> component #6267

Merged
merged 8 commits into from
Jan 11, 2024
Merged

Add <ReadMore> component #6267

merged 8 commits into from
Jan 11, 2024

Conversation

delucis
Copy link
Member

@delucis delucis commented Jan 11, 2024

Description (required)

  • Replaces our 📚 bullets with a <ReadMore> component that adds a stylized open book icon to text instead.

    Usage:

    - 📚 Learn more about [emoji](#emoji)
    + import ReadMore from '~/components/ReadMore.astro';
    +
    + <ReadMore>Learn more about [emoji](#emoji)</ReadMore>
  • Updates our <RecipeLinks> component styles to match <ReadMore> more closely

  • Updates a few instances of the 📚 pattern to use Starlight’s <LinkCard> component instead where that felt more appropriate

Copy link

vercel bot commented Jan 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Jan 11, 2024 8:54pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
docs-i18n ⬜️ Ignored (Inspect) Visit Preview Jan 11, 2024 8:54pm

Co-authored-by: Atharva <[email protected]>
Co-authored-by: Elian <[email protected]>
Co-authored-by: Chris Swithinbank <[email protected]>
Co-authored-by: Paul Valladares <[email protected]>
Co-authored-by: Luiz Ferraz <[email protected]>
Co-authored-by: Dinesh Singh <[email protected]>
Copy link
Contributor

@VoxelMC VoxelMC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome to me, great work everyone!!

Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just left some nits! I think we can clean up a couple of those existing links to have better text describing the link, and I think I like switching up the order on the installation page!

NinuzIBZ added a commit to NinuzIBZ/docs that referenced this pull request Jan 25, 2024
The file `manual.mdx` has been updated to align with the English language documentation based on this commits withastro#6267
ematipico pushed a commit that referenced this pull request Jan 26, 2024
Co-authored-by: Reuben Tier <[email protected]>
Co-authored-by: Atharva <[email protected]>
Co-authored-by: Elian <[email protected]>
Co-authored-by: Chris Swithinbank <[email protected]>
Co-authored-by: Paul Valladares <[email protected]>
Co-authored-by: Luiz Ferraz <[email protected]>
Co-authored-by: Dinesh Singh <[email protected]>
Co-authored-by: Sarah Rainsberger <[email protected]>
Co-authored-by: voxel!() <[email protected]>
ematipico pushed a commit that referenced this pull request Jan 26, 2024
* i18n(fr) Update reading-time.mdx

Just for translator tracker because the PR #5766 should have been [ignore]

* i18n(fr) Update `astro-components.mdx`

Update french translation for astro-components.mdx file with PR #6267

* Update src/content/docs/fr/core-concepts/astro-components.mdx

Co-authored-by: Paul Valladares <[email protected]>

---------

Co-authored-by: Paul Valladares <[email protected]>
ematipico pushed a commit that referenced this pull request Jan 26, 2024
…mdx` (#6363)

* i18n(fr) Update reading-time.mdx

Just for translator tracker because the PR #5766 should have been [ignore]

* Update astro-pages.mdx

* Update framework-components.mdx

* Update layouts.mdx

* Update routing.mdx

* Update editor-setup.mdx

* Update configuring-astro.mdx

* Update cloudflare.mdx

* Update deno.mdx

* Update netlify.mdx

* Update vercel.mdx

* Update imports.mdx

* Update auto.mdx

* Update manual.mdx

* Update cli-reference.mdx

Update and del some parts

* Update cli-reference.mdx

Update fiule with PR #5512 #5651 #5604 #5765 #6040 #6043 #6109 #6267

* Update auto.mdx

* Update cloudflare.mdx

fix PR #5284

* Update markdown-content.mdx

* Update auto.mdx

* Update src/content/docs/fr/core-concepts/astro-pages.mdx

Co-authored-by: Paul Valladares <[email protected]>

* Update src/content/docs/fr/core-concepts/astro-pages.mdx

Co-authored-by: Paul Valladares <[email protected]>

* Update src/content/docs/fr/core-concepts/astro-pages.mdx

Co-authored-by: Paul Valladares <[email protected]>

* Update src/content/docs/fr/core-concepts/framework-components.mdx

Co-authored-by: Paul Valladares <[email protected]>

* Update src/content/docs/fr/core-concepts/framework-components.mdx

Co-authored-by: Paul Valladares <[email protected]>

* Update src/content/docs/fr/guides/markdown-content.mdx

Co-authored-by: Paul Valladares <[email protected]>

* Update src/content/docs/fr/install/manual.mdx

Co-authored-by: Paul Valladares <[email protected]>

* Update src/content/docs/fr/install/manual.mdx

Co-authored-by: Paul Valladares <[email protected]>

* Update src/content/docs/fr/reference/cli-reference.mdx

Co-authored-by: Paul Valladares <[email protected]>

* Apply suggestions from code review

---------

Co-authored-by: Paul Valladares <[email protected]>
ematipico pushed a commit that referenced this pull request Jan 26, 2024
Co-authored-by: liruifengv <[email protected]>
Co-authored-by: Sarah Rainsberger <[email protected]>
yanthomasdev added a commit that referenced this pull request Feb 1, 2024
The file `auto.mdx` has been updated to align with the English language documentation based on this commits #5595 , #6267

Co-authored-by: Yan Thomas <[email protected]>
yanthomasdev added a commit that referenced this pull request Feb 1, 2024
* i18n(it): update install/manual.mdx

The file `manual.mdx` has been updated to align with the English language documentation based on this commits #6267

* i18n(it): update install/manual.mdx

Include changes from cfdf506 commit.

---------

Co-authored-by: Yan Thomas <[email protected]>
fhiromasa added a commit to fhiromasa/astro-docs that referenced this pull request Mar 3, 2024
Add <ReadMore> component (withastro#6267)
yanthomasdev added a commit that referenced this pull request Mar 5, 2024
* Update routing.mdx in ja

Modified to be similar to the English sample code in "Nested Pagination" section

* update routing.mdx in ja

[code-example-syntax] hippo-proof code examples (#5364)

* update routing.mdx in ja

fix: add spacing to 'added in' texts (#5765)

* update routing.mdx in ja

Add <ReadMore> component (#6267)

* Update routing.mdx in ja

Document new routing priority behavior (#6386)

* Update src/content/docs/ja/guides/routing.mdx

Co-authored-by: Shinya Fujino <[email protected]>

* Update src/content/docs/ja/guides/routing.mdx

Co-authored-by: Shinya Fujino <[email protected]>

* Update src/content/docs/ja/guides/routing.mdx

Co-authored-by: Shinya Fujino <[email protected]>

* Update src/content/docs/ja/guides/routing.mdx

Co-authored-by: Shinya Fujino <[email protected]>

* Update src/content/docs/ja/guides/routing.mdx

Co-authored-by: Shinya Fujino <[email protected]>

* Update src/content/docs/ja/guides/routing.mdx

Co-authored-by: Shinya Fujino <[email protected]>

---------

Co-authored-by: Shinya Fujino <[email protected]>
Co-authored-by: Yan <[email protected]>
trueberryless added a commit to trueberryless/withastro-docs that referenced this pull request Oct 22, 2024
yanthomasdev added a commit that referenced this pull request Nov 4, 2024
* update translation #1442

* update translation #1434

* update translation #1510

* update translation #1538

* Update src/content/docs/de/basics/astro-pages.mdx

* Update src/content/docs/de/basics/astro-pages.mdx

* Update src/content/docs/de/basics/astro-pages.mdx

* Update src/content/docs/de/basics/astro-pages.mdx

* Update src/content/docs/de/basics/astro-pages.mdx

* update translation #1638

* update translation #2091

* update translation #2133

* update translation #2409

* update translation #2371

* update translation #4610

* update translation #5128

* update translation #5205

* update translation #5240

* update translation #5364

* update translation #5765

* update translation #6267

* remove paragraph where I cant find when it was deleted in original version

* update translation #6620

* update translation #8495

* update translation #8573

* update translation #9336

* update translation #9336 2/2

didnt save file locally, so git didnt add

* fix all visual differences by comparing manually against original english version

* fix broken links in `astro-pages.mdx`

* Breaking changes to other files! fixing links which link to the �stro-pages.mdx file

* but now...

* Update src/content/docs/de/basics/astro-pages.mdx

Co-authored-by: Max <[email protected]>

* Update src/content/docs/de/basics/astro-pages.mdx

Co-authored-by: Max <[email protected]>

* Update src/content/docs/de/basics/astro-pages.mdx

Co-authored-by: Max <[email protected]>

* revert Update markdown-content.mdx

@lunaria-track:src/content/docs/de/basics/astro-pages.mdx

---------

Co-authored-by: Max <[email protected]>
Co-authored-by: Yan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants