Modifying <head>: clarity and placement in the docs
#1442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for astro-docs-2 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
LGTM @Jutanium! Great call! |
trueberryless
added a commit
to trueberryless/withastro-docs
that referenced
this pull request
Oct 21, 2024
yanthomasdev
added a commit
that referenced
this pull request
Nov 4, 2024
* update translation #1442 * update translation #1434 * update translation #1510 * update translation #1538 * Update src/content/docs/de/basics/astro-pages.mdx * Update src/content/docs/de/basics/astro-pages.mdx * Update src/content/docs/de/basics/astro-pages.mdx * Update src/content/docs/de/basics/astro-pages.mdx * Update src/content/docs/de/basics/astro-pages.mdx * update translation #1638 * update translation #2091 * update translation #2133 * update translation #2409 * update translation #2371 * update translation #4610 * update translation #5128 * update translation #5205 * update translation #5240 * update translation #5364 * update translation #5765 * update translation #6267 * remove paragraph where I cant find when it was deleted in original version * update translation #6620 * update translation #8495 * update translation #8573 * update translation #9336 * update translation #9336 2/2 didnt save file locally, so git didnt add * fix all visual differences by comparing manually against original english version * fix broken links in `astro-pages.mdx` * Breaking changes to other files! fixing links which link to the �stro-pages.mdx file * but now... * Update src/content/docs/de/basics/astro-pages.mdx Co-authored-by: Max <[email protected]> * Update src/content/docs/de/basics/astro-pages.mdx Co-authored-by: Max <[email protected]> * Update src/content/docs/de/basics/astro-pages.mdx Co-authored-by: Max <[email protected]> * revert Update markdown-content.mdx @lunaria-track:src/content/docs/de/basics/astro-pages.mdx --------- Co-authored-by: Max <[email protected]> Co-authored-by: Yan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
<head>section into the Layouts section of/core-concepts/astro-pages<head>tagWhat kind of changes does this PR include?
Description
This addresses #1378.
The behavior of the
<head>tag has little to do with the difference between JSX and Astro components. It does have to do with certain libraries within the React ecosystem, but that is not due to the JSX syntax. Documenting<head>makes more sense in the Layouts section ofAstro Pages, because we recommend using the tag in a Layout, so I moved it there. (I could also see moving this to its own section withinAstro Pages).The section itself was unclear, as #1378 describes. Astro does not have any special handling of
<head>, and I updated the wording to make that more clear.