Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove self-referential link in astro-pages.mdx #9336

Merged
merged 3 commits into from
Sep 7, 2024
Merged

Conversation

sarah11918
Copy link
Member

Removed a section linking to itself.

Took the opportunity to provide better, and future-proof, content collections nudging.

@sarah11918 sarah11918 added the improve documentation Enhance existing documentation (e.g. add an example, improve description) label Sep 7, 2024
Copy link

netlify bot commented Sep 7, 2024

Deploy Preview for astro-docs-2 ready!

Name Link
🔨 Latest commit 4ac7f4d
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/66dca5a1f8e2440008edb824
😎 Deploy Preview https://deploy-preview-9336--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@astrobot-houston
Copy link
Contributor

astrobot-houston commented Sep 7, 2024

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale File Note
en basics/astro-pages.mdx Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@@ -73,9 +73,11 @@ import MySiteLayout from '../layouts/MySiteLayout.astro';

Astro also treats any Markdown (`.md`) files inside of `src/pages/` as pages in your final website. If you have the [MDX Integration installed](/en/guides/integrations-guide/mdx/#installation), it also treats MDX (`.mdx`) files the same way. These are commonly used for text-heavy pages like blog posts and documentation.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are commonly used for text-heavy pages like blog posts and documentation.

I wonder if this sentence contradicts the tip given below since we recommend content collections for blog posts.
But I don't know what is the best use of Markdown pages... Maybe "standalone pages" (e.g. /about, /legal-notice)?

@sarah11918
Copy link
Member Author

!coauthor

Copy link

github-actions bot commented Sep 7, 2024

Co-authored-by: Houston (Bot) <[email protected]>
Co-authored-by: Armand Philippot <[email protected]>

@sarah11918 sarah11918 merged commit a288083 into main Sep 7, 2024
6 checks passed
@sarah11918 sarah11918 deleted the pages-tiny-update branch September 7, 2024 19:13
thomasbnt added a commit to thomasbnt/docs that referenced this pull request Sep 9, 2024
yanthomasdev added a commit that referenced this pull request Sep 11, 2024
* i18n(fr): Update `basics/astro-pages` from #9336

Signed-off-by: Thomas Bonnet <[email protected]>

* Update src/content/docs/fr/basics/astro-pages.mdx

Co-authored-by: Armand Philippot <[email protected]>

* Update src/content/docs/fr/basics/astro-pages.mdx

Co-authored-by: Armand Philippot <[email protected]>

---------

Signed-off-by: Thomas Bonnet <[email protected]>
Co-authored-by: Armand Philippot <[email protected]>
Co-authored-by: Yan <[email protected]>
trueberryless added a commit to trueberryless/withastro-docs that referenced this pull request Oct 22, 2024
trueberryless added a commit to trueberryless/withastro-docs that referenced this pull request Oct 22, 2024
didnt save file locally, so git didnt add
yanthomasdev added a commit that referenced this pull request Nov 4, 2024
* update translation #1442

* update translation #1434

* update translation #1510

* update translation #1538

* Update src/content/docs/de/basics/astro-pages.mdx

* Update src/content/docs/de/basics/astro-pages.mdx

* Update src/content/docs/de/basics/astro-pages.mdx

* Update src/content/docs/de/basics/astro-pages.mdx

* Update src/content/docs/de/basics/astro-pages.mdx

* update translation #1638

* update translation #2091

* update translation #2133

* update translation #2409

* update translation #2371

* update translation #4610

* update translation #5128

* update translation #5205

* update translation #5240

* update translation #5364

* update translation #5765

* update translation #6267

* remove paragraph where I cant find when it was deleted in original version

* update translation #6620

* update translation #8495

* update translation #8573

* update translation #9336

* update translation #9336 2/2

didnt save file locally, so git didnt add

* fix all visual differences by comparing manually against original english version

* fix broken links in `astro-pages.mdx`

* Breaking changes to other files! fixing links which link to the �stro-pages.mdx file

* but now...

* Update src/content/docs/de/basics/astro-pages.mdx

Co-authored-by: Max <[email protected]>

* Update src/content/docs/de/basics/astro-pages.mdx

Co-authored-by: Max <[email protected]>

* Update src/content/docs/de/basics/astro-pages.mdx

Co-authored-by: Max <[email protected]>

* revert Update markdown-content.mdx

@lunaria-track:src/content/docs/de/basics/astro-pages.mdx

---------

Co-authored-by: Max <[email protected]>
Co-authored-by: Yan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improve documentation Enhance existing documentation (e.g. add an example, improve description)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants