Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partials guide #5128

Merged
merged 14 commits into from
Oct 26, 2023
Merged

Partials guide #5128

merged 14 commits into from
Oct 26, 2023

Conversation

matthewp
Copy link
Contributor

Description (required)

This documents partials, an RFC that we plan to release as experimental 3.4.

For Astro version: 3.4. See astro PR #8755.

@netlify
Copy link

netlify bot commented Oct 17, 2023

Deploy Preview for astro-docs-2 ready!

Name Link
🔨 Latest commit f59d98d
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/653a8a3afffdf0000833e828
😎 Deploy Preview https://deploy-preview-5128--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sarah11918
Copy link
Member

Short docs make me happy 😅

Quick early question @matthewp : do you think this makes sense to include directly on the "Pages" page, since this seems directly related to the concept of a page in Astro?

Copy link
Member

@dreyfus92 dreyfus92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome job @matthewp, I left you some minor suggestions. Let me know what are your thoughts.

src/content/docs/en/guides/partials.mdx Outdated Show resolved Hide resolved
src/content/docs/en/guides/partials.mdx Outdated Show resolved Hide resolved
src/content/docs/en/guides/partials.mdx Outdated Show resolved Hide resolved
@matthewp
Copy link
Contributor Author

@sarah11918 Ah yes, that does sound better! Let me update this then.

@sarah11918
Copy link
Member

Perfect! I'll take it from here....

@sarah11918 sarah11918 added add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!) minor-release For the next minor release; in the milestone, "merge queue" when approved by Sarah! labels Oct 20, 2023
@matthewp
Copy link
Contributor Author

Love the new edits, no notes from me.

@sarah11918
Copy link
Member

Note: waiting to find out whether other acceptable page files that can have an export statement (e.g. MDX) can also be partials! If so, we'll update all the times we specify astro pages/components only!

Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready for minor release! 🥳

@sarah11918 sarah11918 merged commit 39eceec into main Oct 26, 2023
9 checks passed
@sarah11918 sarah11918 deleted the partials branch October 26, 2023 15:56
trueberryless added a commit to trueberryless/withastro-docs that referenced this pull request Oct 22, 2024
yanthomasdev added a commit that referenced this pull request Nov 4, 2024
* update translation #1442

* update translation #1434

* update translation #1510

* update translation #1538

* Update src/content/docs/de/basics/astro-pages.mdx

* Update src/content/docs/de/basics/astro-pages.mdx

* Update src/content/docs/de/basics/astro-pages.mdx

* Update src/content/docs/de/basics/astro-pages.mdx

* Update src/content/docs/de/basics/astro-pages.mdx

* update translation #1638

* update translation #2091

* update translation #2133

* update translation #2409

* update translation #2371

* update translation #4610

* update translation #5128

* update translation #5205

* update translation #5240

* update translation #5364

* update translation #5765

* update translation #6267

* remove paragraph where I cant find when it was deleted in original version

* update translation #6620

* update translation #8495

* update translation #8573

* update translation #9336

* update translation #9336 2/2

didnt save file locally, so git didnt add

* fix all visual differences by comparing manually against original english version

* fix broken links in `astro-pages.mdx`

* Breaking changes to other files! fixing links which link to the �stro-pages.mdx file

* but now...

* Update src/content/docs/de/basics/astro-pages.mdx

Co-authored-by: Max <[email protected]>

* Update src/content/docs/de/basics/astro-pages.mdx

Co-authored-by: Max <[email protected]>

* Update src/content/docs/de/basics/astro-pages.mdx

Co-authored-by: Max <[email protected]>

* revert Update markdown-content.mdx

@lunaria-track:src/content/docs/de/basics/astro-pages.mdx

---------

Co-authored-by: Max <[email protected]>
Co-authored-by: Yan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!) minor-release For the next minor release; in the milestone, "merge queue" when approved by Sarah!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants