Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more accessibility sprinkles #1510

Merged
merged 3 commits into from
Sep 10, 2022
Merged

Add more accessibility sprinkles #1510

merged 3 commits into from
Sep 10, 2022

Conversation

yanthomasdev
Copy link
Member

What kind of changes does this PR include?

  • New or updated content

Description

This PR adds more accessibility info to different pages, solving the issues we found in our content accessibility audit.

@yanthomasdev yanthomasdev added the improve documentation Enhance existing documentation (e.g. add an example, improve description) label Sep 8, 2022
@netlify
Copy link

netlify bot commented Sep 8, 2022

Deploy Preview for astro-docs-2 ready!

Name Link
🔨 Latest commit 4c1da63
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/631ca4eecddb94000c2a40a8
😎 Deploy Preview https://deploy-preview-1510--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great sprinkles, Yan! Made a suggestion! 💜

src/pages/en/core-concepts/framework-components.md Outdated Show resolved Hide resolved
Co-authored-by: Sarah Rainsberger <[email protected]>
@sarah11918
Copy link
Member

LGTM! 💜

@yanthomasdev
Copy link
Member Author

Thanks for the review @sarah11918!

@yanthomasdev yanthomasdev merged commit 45d2847 into main Sep 10, 2022
@yanthomasdev yanthomasdev deleted the yan/a11y-sprinkles branch September 10, 2022 15:06
trueberryless added a commit to trueberryless/withastro-docs that referenced this pull request Oct 21, 2024
yanthomasdev added a commit that referenced this pull request Nov 4, 2024
* update translation #1442

* update translation #1434

* update translation #1510

* update translation #1538

* Update src/content/docs/de/basics/astro-pages.mdx

* Update src/content/docs/de/basics/astro-pages.mdx

* Update src/content/docs/de/basics/astro-pages.mdx

* Update src/content/docs/de/basics/astro-pages.mdx

* Update src/content/docs/de/basics/astro-pages.mdx

* update translation #1638

* update translation #2091

* update translation #2133

* update translation #2409

* update translation #2371

* update translation #4610

* update translation #5128

* update translation #5205

* update translation #5240

* update translation #5364

* update translation #5765

* update translation #6267

* remove paragraph where I cant find when it was deleted in original version

* update translation #6620

* update translation #8495

* update translation #8573

* update translation #9336

* update translation #9336 2/2

didnt save file locally, so git didnt add

* fix all visual differences by comparing manually against original english version

* fix broken links in `astro-pages.mdx`

* Breaking changes to other files! fixing links which link to the �stro-pages.mdx file

* but now...

* Update src/content/docs/de/basics/astro-pages.mdx

Co-authored-by: Max <[email protected]>

* Update src/content/docs/de/basics/astro-pages.mdx

Co-authored-by: Max <[email protected]>

* Update src/content/docs/de/basics/astro-pages.mdx

Co-authored-by: Max <[email protected]>

* revert Update markdown-content.mdx

@lunaria-track:src/content/docs/de/basics/astro-pages.mdx

---------

Co-authored-by: Max <[email protected]>
Co-authored-by: Yan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improve documentation Enhance existing documentation (e.g. add an example, improve description)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Content audit for Accessibility guidance
2 participants