Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n(de): update guides/deploy/vercel.mdx #9963

Merged
merged 6 commits into from
Nov 14, 2024
Merged

Conversation

maxzirps
Copy link
Contributor

@maxzirps maxzirps commented Nov 9, 2024

Description (required)

updated german translation of src/content/docs/de/guides/deploy/vercel.mdx

Related issues & labels & PRs

#8217
#8167
#6267

@github-actions github-actions bot added the i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! label Nov 9, 2024
Copy link

netlify bot commented Nov 9, 2024

Deploy Preview for astro-docs-2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 5c9da07
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/6735a111eda86300083ac43b
😎 Deploy Preview https://deploy-preview-9963--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@astrobot-houston
Copy link
Contributor

Hello! Thank you for opening your first PR to Astro’s Docs! 🎉

Here’s what will happen next:

  1. Our GitHub bots will run to check your changes.
    If they spot any broken links you will see some error messages on this PR.
    Don’t hesitate to ask any questions if you’re not sure what these mean!

  2. In a few minutes, you’ll be able to see a preview of your changes on Netlify 🥳.

  3. One or more of our maintainers will take a look and may ask you to make changes.
    We try to be responsive, but don’t worry if this takes a few days.

@astrobot-houston
Copy link
Contributor

astrobot-houston commented Nov 9, 2024

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
de/guides/deploy/vercel.mdx Localization changed, will be marked as complete.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@jsparkdev
Copy link
Contributor

jsparkdev commented Nov 13, 2024

Feedback and questions about code you've modified.

This is not the code you modified, but it would be nice if you could update the following

  1. line 26 seems to be missing the inline code highlighting.
  2. on line 86, the CLI asks a question in English, but it looks like this question has been translated.

Thank you for your contribution.

Copy link
Contributor

@trueberryless trueberryless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉 nvm, our newest maintainer is on fire with those reviews! 🎉 Good catch, @jsparkdev

Just create a newline at the EOF (end of file) because if consistency please 🥺!

src/content/docs/de/guides/deploy/vercel.mdx Outdated Show resolved Hide resolved
@maxzirps
Copy link
Contributor Author

maxzirps commented Nov 14, 2024

Nice findings @jsparkdev

Thanks for the feedback. I have updated the code

Copy link
Contributor

@jsparkdev jsparkdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jsparkdev jsparkdev merged commit 03bcdf8 into withastro:main Nov 14, 2024
10 checks passed
@maxzirps maxzirps deleted the patch-2 branch November 14, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants