Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Trends #1123

Merged
merged 14 commits into from
Jun 20, 2024
Merged

feat: Trends #1123

merged 14 commits into from
Jun 20, 2024

Conversation

alflennik and others added 9 commits May 2, 2024 16:50
* Add minimum or exact at version to reports

* Quick tweak

* Revert home copy change

* Remove unused field from createTestPlanReport

* Fix undefined var

* Prevent API from creating duplicate reports

* Add atVersion frontend

* Make sure automation dialog always shows when valid

* Make sure existing reports have a minimum at version

* Simplify jsx string

Co-authored-by: Howard Edwards <[email protected]>

---------

Co-authored-by: Howard Edwards <[email protected]>
* Add minimum or exact at version to reports

* Quick tweak

* Revert home copy change

* Remove unused field from createTestPlanReport

* Fix undefined var

* Prevent API from creating duplicate reports

* Support primary test plan to be selected

* Fix test

* Add dialog when marking report as final for an admin to select from probably primary test run options

* prioritised -> prioritized typo (british -> american english)

* Avoid displaying primary test plan run confirmation when just 1 run option

* Add atVersion frontend

* Make sure automation dialog always shows when valid

* Make sure existing reports have a minimum at version

* Formatting

* feat: Add resolver for tracking first required AT Version (#1051) Address #792

* Add resolver for finding firstRequiredAtVersion for a RECOMMENDED TestPlanVersion, given an atId

* Update tests

* Fix graphql call when including "firstRequiredAtVersion" under "testPlanVersions"

* Update description of firstRequiredAtVersion

* Rename resolver

---------

Co-authored-by: alflennik <[email protected]>
* Add minimum or exact at version to reports

* Quick tweak

* Revert home copy change

* Remove unused field from createTestPlanReport

* Fix undefined var

* Prevent API from creating duplicate reports

* Add atVersion frontend

* Make sure automation dialog always shows when valid

* Make sure existing reports have a minimum at version

* Update status dialog for minimum exact AT versions

* Update server/resolvers/TestPlanVersion/testPlanReportStatusesResolver.js

Co-authored-by: Howard Edwards <[email protected]>

---------

Co-authored-by: Howard Edwards <[email protected]>
…s RECOMMENDED (#1052)

* Add minimum or exact at version to reports

* Quick tweak

* Revert home copy change

* Remove unused field from createTestPlanReport

* Fix undefined var

* Prevent API from creating duplicate reports

* Support primary test plan to be selected

* Fix test

* Add resolver for finding firstRequiredAtVersion for a RECOMMENDED TestPlanVersion, given an atId

* Add dialog when marking report as final for an admin to select from probably primary test run options

* prioritised -> prioritized typo (british -> american english)

* Update tests

* Track recommended AT version

* Avoid displaying primary test plan run confirmation when just 1 run option

* Fix graphql call when including "firstRequiredAtVersion" under "testPlanVersions"

* Update description of firstRequiredAtVersion

* Add atVersion frontend

* Make sure automation dialog always shows when valid

* Rename resolver

* Make sure existing reports have a minimum at version

* Formatting

* Fix graphql calls when doing testPlanReports > recommendedAtVersion

* feat: Add resolver for tracking first required AT Version (#1051) Address #792

* Add resolver for finding firstRequiredAtVersion for a RECOMMENDED TestPlanVersion, given an atId

* Update tests

* Fix graphql call when including "firstRequiredAtVersion" under "testPlanVersions"

* Update description of firstRequiredAtVersion

* Rename resolver

* Use exactAtVersionId if available for recommendedAtVersion

* Update comment

---------

Co-authored-by: alflennik <[email protected]>
…#1087)

* Add minimum or exact at version to reports

* Quick tweak

* Revert home copy change

* Remove unused field from createTestPlanReport

* Fix undefined var

* Prevent API from creating duplicate reports

* Support primary test plan to be selected

* Fix test

* Add dialog when marking report as final for an admin to select from probably primary test run options

* prioritised -> prioritized typo (british -> american english)

* Avoid displaying primary test plan run confirmation when just 1 run option

* Add atVersion frontend

* Make sure automation dialog always shows when valid

* Make sure existing reports have a minimum at version

* Formatting

* feat: Add resolver for tracking first required AT Version (#1051) Address #792

* Add resolver for finding firstRequiredAtVersion for a RECOMMENDED TestPlanVersion, given an atId

* Update tests

* Fix graphql call when including "firstRequiredAtVersion" under "testPlanVersions"

* Update description of firstRequiredAtVersion

* Rename resolver

* Update status dialog for minimum exact AT versions

* Recommended phase uses exact AT version

* Remove unneeded ternary

* Fix issue caused by using draft reports

* Reduce number of at versions shown in status dialog

* Fix unused var

* Fix incorrect required browser

* Address PR feedback

---------

Co-authored-by: Howard Edwards <[email protected]>
* Add at version row to test queue

* Fix client tests

* Revert ats.json

* Update column title

* fix crash when assigning/unassigning

---------

Co-authored-by: Howard Edwards <[email protected]>
# Conflicts:
#	server/handlebars/embed/public/style.css
@howard-e howard-e changed the title Trends and Test Queue v2 feat: Trends and Test Queue v2 Jun 5, 2024
@howard-e howard-e changed the title feat: Trends and Test Queue v2 feat: Trends Jun 5, 2024
howard-e added 3 commits June 5, 2024 16:35
# Conflicts:
#	client/components/AddTestToQueueWithConfirmation/index.jsx
#	client/tests/__mocks__/GraphQLMocks/DataManagementPagePopulatedMock.js
#	client/tests/__mocks__/GraphQLMocks/TestPlanReportStatusDialogMock.js
#	client/tests/__mocks__/GraphQLMocks/TestQueuePageAdminPopulatedMock.js
#	server/resolvers/TestPlanVersionOperations/updatePhaseResolver.js
#	server/scripts/populate-test-data/pg_dump_test_data.sql
#	server/tests/integration/dataManagement.test.js
… version selection modal (#1131)

* Prevent AT versions before the minimum specified being included in AtAndBrowserDetailsModal
* Include disclaimer message and prevent AT Version selection when exact AT version is set
@howard-e howard-e marked this pull request as ready for review June 20, 2024 18:04
Addresses #791 (comment)

---------

Co-authored-by: Paul Clue <[email protected]>
Co-authored-by: alflennik <[email protected]>
@howard-e howard-e merged commit af8f492 into development Jun 20, 2024
2 checks passed
@howard-e howard-e deleted the trends branch June 20, 2024 21:19
howard-e added a commit that referenced this pull request Jun 24, 2024
Includes the following changes:
* #1123, addresses #791 and #792 with:
  * #1055
  * #1001
  * #1065
  * #1052 
  * #1087
  * #1098 
  * #1092
  * #1131
  * #1124
* #1128, addresses #1100
* #1102, addresses #957
* #1132
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants