-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Trends #1123
Merged
Merged
feat: Trends #1123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add minimum or exact at version to reports * Quick tweak * Revert home copy change * Remove unused field from createTestPlanReport * Fix undefined var * Prevent API from creating duplicate reports * Add atVersion frontend * Make sure automation dialog always shows when valid * Make sure existing reports have a minimum at version * Simplify jsx string Co-authored-by: Howard Edwards <[email protected]> --------- Co-authored-by: Howard Edwards <[email protected]>
* Add minimum or exact at version to reports * Quick tweak * Revert home copy change * Remove unused field from createTestPlanReport * Fix undefined var * Prevent API from creating duplicate reports * Support primary test plan to be selected * Fix test * Add dialog when marking report as final for an admin to select from probably primary test run options * prioritised -> prioritized typo (british -> american english) * Avoid displaying primary test plan run confirmation when just 1 run option * Add atVersion frontend * Make sure automation dialog always shows when valid * Make sure existing reports have a minimum at version * Formatting * feat: Add resolver for tracking first required AT Version (#1051) Address #792 * Add resolver for finding firstRequiredAtVersion for a RECOMMENDED TestPlanVersion, given an atId * Update tests * Fix graphql call when including "firstRequiredAtVersion" under "testPlanVersions" * Update description of firstRequiredAtVersion * Rename resolver --------- Co-authored-by: alflennik <[email protected]>
* Add minimum or exact at version to reports * Quick tweak * Revert home copy change * Remove unused field from createTestPlanReport * Fix undefined var * Prevent API from creating duplicate reports * Add atVersion frontend * Make sure automation dialog always shows when valid * Make sure existing reports have a minimum at version * Update status dialog for minimum exact AT versions * Update server/resolvers/TestPlanVersion/testPlanReportStatusesResolver.js Co-authored-by: Howard Edwards <[email protected]> --------- Co-authored-by: Howard Edwards <[email protected]>
…s RECOMMENDED (#1052) * Add minimum or exact at version to reports * Quick tweak * Revert home copy change * Remove unused field from createTestPlanReport * Fix undefined var * Prevent API from creating duplicate reports * Support primary test plan to be selected * Fix test * Add resolver for finding firstRequiredAtVersion for a RECOMMENDED TestPlanVersion, given an atId * Add dialog when marking report as final for an admin to select from probably primary test run options * prioritised -> prioritized typo (british -> american english) * Update tests * Track recommended AT version * Avoid displaying primary test plan run confirmation when just 1 run option * Fix graphql call when including "firstRequiredAtVersion" under "testPlanVersions" * Update description of firstRequiredAtVersion * Add atVersion frontend * Make sure automation dialog always shows when valid * Rename resolver * Make sure existing reports have a minimum at version * Formatting * Fix graphql calls when doing testPlanReports > recommendedAtVersion * feat: Add resolver for tracking first required AT Version (#1051) Address #792 * Add resolver for finding firstRequiredAtVersion for a RECOMMENDED TestPlanVersion, given an atId * Update tests * Fix graphql call when including "firstRequiredAtVersion" under "testPlanVersions" * Update description of firstRequiredAtVersion * Rename resolver * Use exactAtVersionId if available for recommendedAtVersion * Update comment --------- Co-authored-by: alflennik <[email protected]>
…#1087) * Add minimum or exact at version to reports * Quick tweak * Revert home copy change * Remove unused field from createTestPlanReport * Fix undefined var * Prevent API from creating duplicate reports * Support primary test plan to be selected * Fix test * Add dialog when marking report as final for an admin to select from probably primary test run options * prioritised -> prioritized typo (british -> american english) * Avoid displaying primary test plan run confirmation when just 1 run option * Add atVersion frontend * Make sure automation dialog always shows when valid * Make sure existing reports have a minimum at version * Formatting * feat: Add resolver for tracking first required AT Version (#1051) Address #792 * Add resolver for finding firstRequiredAtVersion for a RECOMMENDED TestPlanVersion, given an atId * Update tests * Fix graphql call when including "firstRequiredAtVersion" under "testPlanVersions" * Update description of firstRequiredAtVersion * Rename resolver * Update status dialog for minimum exact AT versions * Recommended phase uses exact AT version * Remove unneeded ternary * Fix issue caused by using draft reports * Reduce number of at versions shown in status dialog * Fix unused var * Fix incorrect required browser * Address PR feedback --------- Co-authored-by: Howard Edwards <[email protected]>
* Add at version row to test queue * Fix client tests * Revert ats.json * Update column title * fix crash when assigning/unassigning --------- Co-authored-by: Howard Edwards <[email protected]>
# Conflicts: # server/handlebars/embed/public/style.css
# Conflicts: # client/components/AddTestToQueueWithConfirmation/index.jsx # client/tests/__mocks__/GraphQLMocks/DataManagementPagePopulatedMock.js # client/tests/__mocks__/GraphQLMocks/TestPlanReportStatusDialogMock.js # client/tests/__mocks__/GraphQLMocks/TestQueuePageAdminPopulatedMock.js # server/resolvers/TestPlanVersionOperations/updatePhaseResolver.js # server/scripts/populate-test-data/pg_dump_test_data.sql # server/tests/integration/dataManagement.test.js
… version selection modal (#1131) * Prevent AT versions before the minimum specified being included in AtAndBrowserDetailsModal * Include disclaimer message and prevent AT Version selection when exact AT version is set
Addresses #791 (comment) --------- Co-authored-by: Paul Clue <[email protected]> Co-authored-by: alflennik <[email protected]>
This was referenced Jun 20, 2024
howard-e
added a commit
that referenced
this pull request
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes work to support #791 and #792.
Includes the following changes: