Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display AT Version for finalized reports when TestPlanVersion is RECOMMENDED #1052

Merged
merged 35 commits into from
May 8, 2024
Merged

Display AT Version for finalized reports when TestPlanVersion is RECOMMENDED #1052

merged 35 commits into from
May 8, 2024

Conversation

howard-e
Copy link
Contributor

@howard-e howard-e commented Apr 9, 2024 •
edited
Loading

This PR now displays an AT version on the following report pages when the TestPlanVersion it is linked to is in the RECOMMENDED phase.

/report/<id>

  • Includes AT version for each AT + Browser h2 heading

/report/<id>/targets/<id>

  • Now includes AT Version in title of page
  • Now includes AT Version in h1 on page
  • Now includes AT Version in navigation breadcrumb for current location

This follows discussions from #792 (comment):

  • When a test plan version is promoted to recommended, the AT version should be included in the title (eg. from "Alert with NVDA and Firefox" to "Alert with NVDA 2023.3 and Firefox")
  • When upgrading a report to recommended, the first required AT version will be what’s displayed. Otherwise it will be what’s specified by the test admin when adding new reports to the test queue for a test plan that has already been recommended.

alflennik and others added 30 commits April 3, 2024 13:37
@alflennik
Add minimum or exact at version to reports
e563863
@alflennik
Quick tweak
f233b0f
@alflennik
Revert home copy change
5d7ef54
@alflennik
Remove unused field from createTestPlanReport
408b3f1
@alflennik
Fix undefined var
1d140c0
@alflennik
Prevent API from creating duplicate reports
9695e4f
@howard-e
Support primary test plan to be selected
64e08b2
@howard-e
Fix test
9321c83
@howard-e
Add resolver for finding firstRequiredAtVersion for a RECOMMENDED Tes…
66e6a12 
…tPlanVersion, given an atId
@howard-e
Add dialog when marking report as final for an admin to select from p…
a17112e 
…robably primary test run options
@howard-e
prioritised -> prioritized typo (british -> american english)
c98e7b3
@howard-e
Merge branch 'refs/heads/primaryTestPlanRun' into trackFirstRequiredA…
3b7e300 
…tVersion
@howard-e
Update tests
48d889c
@howard-e
Track recommended AT version
d423d33
@howard-e
Avoid displaying primary test plan run confirmation when just 1 run o…
b738bc0 
…ption
@howard-e
Merge branch 'refs/heads/development' into primaryTestPlanRun
b3d02b3
@howard-e
Merge branch 'refs/heads/primaryTestPlanRun' into trackFirstRequiredA…
1bd62ad 
…tVersion
@howard-e
Merge branch 'refs/heads/trackFirstRequiredAtVersion' into trackRecom…
7bcbd25 
…mendedAtVersion
@howard-e
Fix graphql call when including "firstRequiredAtVersion" under "testP…
21a0c72 
…lanVersions"
@howard-e
Update description of firstRequiredAtVersion
b916caf
@alflennik
Add atVersion frontend
f60af79
@alflennik
Make sure automation dialog always shows when valid
874dd55
@howard-e
Rename resolver
54cc553
@alflennik
Merge branch 'can-duplicate-test-plan-reports' into minimum-exact-at-…
099477f 
…version
@alflennik
Make sure existing reports have a minimum at version
ea97ee5
@howard-e
Formatting
87aa47a
@howard-e
Merge branch 'refs/heads/primaryTestPlanRun' into trackFirstRequiredA…
3295713 
…tVersion
@howard-e
Merge branch 'refs/heads/trackFirstRequiredAtVersion' into trackRecom…
2a0e7d2 
…mendedAtVersion

# Conflicts:
#	server/tests/integration/graphql.test.js
@howard-e
Fix graphql calls when doing testPlanReports > recommendedAtVersion
2efbe39
@howard-e
feat: Add resolver for tracking first required AT Version (#1051) Add…
f1d2203 
…ress #792

* Add resolver for finding firstRequiredAtVersion for a RECOMMENDED TestPlanVersion, given an atId

* Update tests

* Fix graphql call when including "firstRequiredAtVersion" under "testPlanVersions"

* Update description of firstRequiredAtVersion

* Rename resolver
Base automatically changed from trackFirstRequiredAtVersion to primaryTestPlanRun April 24, 2024 21:05
@howard-e howard-e marked this pull request as ready for review April 25, 2024 16:39
@howard-e howard-e requested a review from alflennik April 25, 2024 16:39
Base automatically changed from primaryTestPlanRun to trends May 2, 2024 21:00
@howard-e
Merge branch 'refs/heads/trends' into trackRecommendedAtVersion
47bcd4b 
# Conflicts:
#	client/components/AddTestToQueueWithConfirmation/index.jsx
#	server/graphql-schema.js
#	server/resolvers/TestPlanVersion/index.js
#	server/tests/integration/graphql.test.js
alflennik
alflennik approved these changes May 8, 2024
View reviewed changes
Copy link
Contributor

@alflennik alflennik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, tests are passing, verified the new UI is showing as intended, also nice job on the resolver that was really easy to follow. Happy to approve!

@alflennik alflennik merged commit 19900a4 into trends May 8, 2024
2 checks passed
@alflennik alflennik deleted the trackRecommendedAtVersion branch May 8, 2024 18:50
@howard-e howard-e mentioned this pull request Jun 20, 2024
Merged
howard-e added a commit that referenced this pull request Jun 20, 2024
@howard-e @Paul-Clue @alflennik
feat: Trends (#1123)
af8f492 
This includes work to support #791 and #792.

Includes the following changes:
* #1055
* #1001
* #1065
* #1052 
* #1087
* #1098 
* #1092
* #1131
* #1124

---------

Co-authored-by: Howard Edwards <[email protected]>
Co-authored-by: Paul Clue <[email protected]>
Co-authored-by: alflennik <[email protected]>
@howard-e howard-e mentioned this pull request Jun 24, 2024
Merged
howard-e added a commit that referenced this pull request Jun 24, 2024
@howard-e
Merge pull request #1133 from w3c/development
a2b8253 
Includes the following changes:
* #1123, addresses #791 and #792 with:
  * #1055
  * #1001
  * #1065
  * #1052 
  * #1087
  * #1098 
  * #1092
  * #1131
  * #1124
* #1128, addresses #1100
* #1102, addresses #957
* #1132
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alflennik alflennik alflennik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@howard-e @alflennik