fix: use correct test number sequence for raising github issues

[stalgiag]

This PR modifies createIssueLink() so that it accepts a new property in the options param, testSequenceNumber. In all instances where this function is used, the generated number used for rendering the test number ("Test X:") is passed. This handles confusion about which test is referenced when creating issues. The test row number which is now decoupled from the specific report's sequence is still stored in the hiddenMetadata of the issue.

I wanted to add a unit test but this would be difficult with the current design of this method since the testable logic for this particular problem has more to do with the generated sequence passed in. I can think of ways to adjust the design but none is an absolute win so I decided this was out of scope. Let me know if reviewers think otherwise.

addresses #1110

---

• To see the specific tasks where the Asana app for GitHub is being used, see below:
  • https://app.asana.com/0/0/1207383005191128

[gnarf]

Might be worth adding some propTypes for verification of params to this.

Also noticed at the bottom there is a "query" still using the old testRowNumber

[stalgiag]

Good call! Didn't even notice the query down there.

Addressed in ddb515b and f04ad78 respectively.

Note that we won't get actual param verification since this isn't a React component and we aren't using Typescript but went for the best we can offer for now, JSDoc.

[gnarf]

very simple change needed IMO (the query should be updated to use the correct sequence number instead of row number)

[howard-e]

@stalgiag left an inline change request. All the other changes look good to me

[howard-e]

Looks good! Thanks for addressing the feedback