Specify primary Test Plan Run when finalizing report and track first required AT Version #1001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…robably primary test run options
howard-e
changed the title
evmiguel
approved these changes
Apr 10, 2024
| title="Select Primary Test Plan Run" | ||
| content={ | ||
| <> | ||
| When a tester's run is marked as primary, it means |
There was a problem hiding this comment.
Can we style this at the break point to have whitespace?
| padding: 0.75rem; | ||
| } */ | ||
| .primary-test-run-select { | ||
| padding: 0 !important; |
There was a problem hiding this comment.
Can we add a padding left to the select?
There was a problem hiding this comment.
I realize now what was being shown is because the dialog still appears when the number of testers to choose from is 1 and <select>.size would render differently.
I've pushed b738bc0 which should won't display the dialog at all if there's only 1 tester to choose from. Thanks for pointing this out!
|
Looks good @howard-e! |
…ress #792 * Add resolver for finding firstRequiredAtVersion for a RECOMMENDED TestPlanVersion, given an atId * Update tests * Fix graphql call when including "firstRequiredAtVersion" under "testPlanVersions" * Update description of firstRequiredAtVersion * Rename resolver
…anRun # Conflicts: # server/tests/integration/graphql.test.js
howard-e
changed the title
Merged
howard-e
added a commit
that referenced
this pull request
Jun 20, 2024
This includes work to support #791 and #792. Includes the following changes: * #1055 * #1001 * #1065 * #1052 * #1087 * #1098 * #1092 * #1131 * #1124 --------- Co-authored-by: Howard Edwards <[email protected]> Co-authored-by: Paul Clue <[email protected]> Co-authored-by: alflennik <[email protected]>
howard-e
added a commit
that referenced
this pull request
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for selecting a "Primary test plan run" as outlined in #792.
TestPlanRuntable to trackisPrimaryas an attributemarkAsFinalresolver to take aprimaryTestPlanRunIdwhich indicates which test run a report should be considered the "primary"Note: This PR also includes #1051 which was reviewed and approved separately