Add resolver for tracking first required AT Version

[howard-e]

This PR adds support for tracking "First Required AT Versions as outlined in #792.

• Includes firstRequiredAtVersion on graphql schema's TestPlanVersion. When provided an AT id, given that a report has been generated for that test plan version with that AT, it will follow defined rules to return the first required AT version for a TestPlanVersion once it has gotten to RECOMMENDED.

Since this is work is also dependent on a "primary test plan run", this is branched off of the work being done on #1001.

[alflennik]

I got this error with the query

query { 
  testPlanVersions {
    id
    title
    versionString
    firstRequiredAtVersion(atId: 1) {
 			id
    }
  }
}

Any idea what might be causing this?

This is with a fresh database and the sample data.

[alflennik]

Just a couple of notes! The main thing is that I encountered an error in the graphql playground.

[alflennik]

I was wondering, how do you feel about calling this earliestMissingAtVersion? I feel like "missing" might be more descriptive than "required", possibly?

[howard-e]

The "required" in the name relates to the description provided for required reports. "Missing" feels slightly different here for 2 reasons:

1. Initially, the name seems like it would return a value that should exist, but doesn't, which isn't what this value is
2. If the following is okay though, a "missing" AT Version may not necessarily be the same as a "required" AT version. For example if VO + Firefox got to recommended with any other VO + Browser combinations (not actually possible), it shouldn't produce a result for this based on the description in Update report status dialog for recommended test plans to include information about required AT/Browser versions #792, since it isn't "required"

I was also thinking the first -> earliest may cause confusion since it deviates from what was originally proposed but that is currently conceptual and earliest does feel a bit more clear and aligns with other variables in the schema.

Based on the above though, this variable could really be earliestRequiredWhenRecommendedAtVersion (or similar) if I wanted to fully self-document. But the descriptions around this value help should make this clear. So to avoid further confusion and increased verbosity, how about just earliestAtVersion?

I've also created a Business Logic Wiki so the definitions of these concepts aren't also lost outside the context of the graphql schema or whatever else other internal app logic.

[alflennik]

Thanks!

[alflennik]

I appreciate the depth of this explanation, but even so I had a hard time understanding what this field really means. Would it be possible to describe it in terms of how exactly it fits into the workflow for test plans?

[howard-e]

Updated in b916caf. Does that help to clarify?

[howard-e]

I got this error with the query

query { 
  testPlanVersions {
    id
    title
    versionString
    firstRequiredAtVersion(atId: 1) {
 			id
    }
  }
}

Any idea what might be causing this?

This is with a fresh database and the sample data.

21a0c72 should fix this. Because of how the testPlanVersionsResolver is done, the testPlanReports and phase variables were being left out which would then throw the error.

[alflennik]

I verified that this is working perfectly now. And thanks for addressing all my feedback.