Only allow exact AT versions for recommended test plan versions #1087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…robably primary test run options
…ress #792 * Add resolver for finding firstRequiredAtVersion for a RECOMMENDED TestPlanVersion, given an atId * Update tests * Fix graphql call when including "firstRequiredAtVersion" under "testPlanVersions" * Update description of firstRequiredAtVersion * Rename resolver
…anRun # Conflicts: # server/tests/integration/graphql.test.js
howard-e
approved these changes
May 8, 2024
| onSelect={exactOrMinimum => | ||
| onSelect={exactOrMinimum => { | ||
| if ( | ||
| selectedTestPlanVersion.phase === |
There was a problem hiding this comment.
Suggested change
| selectedTestPlanVersion.phase === | |
| selectedTestPlanVersion?.phase === |
| @@ -336,6 +342,7 @@ const ManageTestQueue = ({ | |||
| }; | |||
|
|
|||
| const onAtChange = e => { | |||
| setShowMinimumAtVersionErrorMessage(false); | |||
There was a problem hiding this comment.
nit: for consistency, can you move this a line below?
There was a problem hiding this comment.
haha ok, I'll grant you it's an improvement
Merged
howard-e
added a commit
that referenced
this pull request
Jun 20, 2024
This includes work to support #791 and #792. Includes the following changes: * #1055 * #1001 * #1065 * #1052 * #1087 * #1098 * #1092 * #1131 * #1124 --------- Co-authored-by: Howard Edwards <[email protected]> Co-authored-by: Paul Clue <[email protected]> Co-authored-by: alflennik <[email protected]>
howard-e
added a commit
that referenced
this pull request
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements restrictions to prevent reports being created with a minimum AT version once the test plan version has reached the recommended phase.