CDI Lite compliance (CDI 4.0)

[Ladicek]

Description

I intend to eventually make ArC fully compliant with the CDI Lite part of CDI 4.0. This entails:

• implementing Build Compatible Extensions in ArC
• implementing an Arquillian adapter for ArC
• adding a CDI TCK runner module to ArC
• most likely adding a special mode (off by default) that enables strict spec compliance
• fixing the issues found by the TCK

This issue is a tracker for all that. Work will start on this when Quarkus mainline switches to Jakarta EE 10 dependencies and ArC specifically switches to CDI 4.0.

Implementation ideas

I actually have quite a lot of that already implemented on a non-public branch (that I've been rebasing for more than 2 years actually). Specifically:

• Arquillian adapter is implemented (could be submitted now, but would cause too much churn), together with a simple CDI Lite TCK runner module
• Build Compatible Extensions are implemented and pass all the relevant CDI TCK tests

What I didn't focus on yet is passing the full CDI Lite TCK. As is, ArC passes roughly 1/2 of the CDI Lite TCK, so there's quite some work to do. I expect that some tests in the CDI Lite TCK are always going to fail due to some improvements we made in ArC and are not willing to give up -- for that reason, I expect we'll have to add a switch for enabling strict spec compliance at the cost of foregoing the improvements. That switch will be off by default, but we'll turn it on to pass the TCK. Users will also be able to turn it on if they so desire.

List of related PRs

• Arc - remove wildcard types from bean types of class-based beans #30447
• Arc - Using @Typed with illegal values should throw an exception #30452
• ArC fixes for spec compatibility #30509
• Arc - compare types declared by @Typed with unrestricted bean types instead of actual types #30544
• ArC fixes for spec compatibility, round 2 #30666
• Arc - validate Event#select and Event#fire methods for type variables #30917
• ArC fixes for spec compatibility, round 3 #30924
• Various changes to observer methods to align them with spec expectations #30950
• ArC: EventMetadata - implement the getInjectionPoint() method #31062
• Arc - validate Event raw type injection points and throw DefinitionException when found #31085
• ArC fixes for spec compatibility, round 4 #31248
• Arc - Validate whether interceptors declare producer methods #31348
• ArC: initial implementation of CDI Build Compatible Extensions #31444
• ArC TCKs #31589
• ArC fixes for spec compatibility, round 5 #31702
• ArC fixes for spec compatibility, round 6 #31814
• Arc CDI TCK related fixes, focused around behavior gated behind strict mode #32407
• ArC - support multiple interceptor methods in a class hierarchy and around invoke method declared on target class #32730
• ArC fixes for spec compatibility, round 7 #32885
• ArC - fix CreationalContext handling when used directly with BeanManager #32945
• Arc: Implement validation for various erroneous cases of bean metadata, re-enable TCK tests #32984
• ArC fixes for spec compatibility, round 8 #33051
• ArC fixes for spec compatibility, round 9 #33447
• ArC fixes for spec compatibility, round 10 #33523
• Jakarta TCKs #33638
• ArC: update CDI documentation with references to CDI 4.0 and CDI Lite #33719

[quarkus-bot]

/cc @manovotn, @mkouba

[Ladicek]

I have cleaned up my local branch, rebased on current Quarkus main and published it here: https://github.com/Ladicek/quarkus-jakarta-arc This repository only includes ArC, which is where the vast majority of changes are. This makes it much easier to experiment with. There's a tiny amount of changes required in Quarkus (core and the ArC extension) that are not published in that repository (something like 10 or 20 lines of code), which I don't think is a big deal.

[manovotn]

FYI @n1hility, this issue nicely captures what we've been talking about

[mkouba]

@Ladicek @manovotn What's the current compliance status?

[manovotn]

Right now there are roughly 48 failing test classes to sort through.
An estimate of what we need to work on is:

• interceptor TCKs (those went pretty much untouched so far)
• proper implementation of dependent context which the TCK expects
• tests around circular bean dependencies
• missing impl of Bean.getInjectionPoints() in Arc

Otherwise, rest of the TCKs are executed with each PR.
The current list of exlusions can be seen directly in the code.

[Ladicek]

I filed a few issues that we can consider post-CDI 4.0 tasks:

• Support custom CDI contexts implementing AlterableContext #33664
• Clarify the behavior of InstanceHandle.close() #33665
• Clarify class-level interceptor binding inheritance #33666
• Simplify unproxyability errors #33668