ArC: initial implementation of CDI Build Compatible Extensions

[Ladicek]

Related to #28558

Vast majority of changes are additions that are pretty well isolated. To review, it's probably best to focus on changes to already existing files.

I plan to submit another PR with additions of the CDI TCK runner modules, as this PR is huge already.

[mkouba]

Quarkus 3.6??

[Ladicek]

I'm thinking roughly 6 months after the Quarkus release in which this would happen, which is 3.0. Given our roughly monthly release cadence, that's 3.6. Do you have another preference?

[mkouba]

I'd say that Deprecated.forRemoval()=true is enough - BeanInfo.Builder.alternativePriority(Integer) is not part of the public API.

[Ladicek]

Added @Deprecated(forRemoval = true, since = "3.0").

[gsmet]

I would recommend to rather use since = "3.0" in the @Deprecated annotation.

We never really give estimate of when something will be removed. But us knowing when it was removed is useful for knowing when it's relatively safe to remove something.

[Ladicek]

We actually often do that in ArC, but adding since is a great point, I'll do that.

[mkouba]

+1 for since

[Ladicek]

Added @Deprecated(forRemoval = true, since = "3.0").

[Ladicek]

Added @Deprecated(forRemoval = true, since = "3.0") to the elements deprecated in this PR, plus created another commit to add the same to elements that were deprecated for removal recently.

[Ladicek]

Made the changes we discussed earlier today. One thing I forgot: I'd appreciate a second pair of eyes on the changes to InstanceImpl. We can discuss that offline, but there are 2 main changes:

1. Add a way to construct an Instance<Object> for the @Synthesis phase, which prevents looking up InjectionPoint for non-@Dependent beans.
2. Added ability to disable resetting the "current" injection point, which is also required for @Synthesis.

Maybe I should replace this code with synthetic injection points, as introduced recently. That might simplify things a lot, though I'm not sure it fully implements all the peculiarities of looking up a "current" injection point.

[mkouba]

Maybe I should replace this code with synthetic injection points, as introduced recently.

+1

That might simplify things a lot, though I'm not sure it fully implements all the peculiarities of looking up a "current" injection point.

What peculiarities do you have in mind? You can take a look at the SyntheticInjectionPointMetadataTest and SyntheticInjectionPointMetadataInvalidTest to see what's tested (hence supported ;-).

[Ladicek]

Rebased to avoid the failures.

After offline discussion, I left InstanceImpl.forSynthesis() in place instead of replacing it with a synthetic injection point of type Instance<Object>, because that would effectively turn off unused bean removal in presence of any BCExtension that creates a synthetic bean.

[quarkus-bot]

Failing Jobs - Building 50d4034

Status	Name	Step	Failures	Logs	Raw logs
✖	Native Tests - Misc4	Build	Failures	Logs	Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ Native Tests - Misc4 #

- Failing: integration-tests/opentelemetry-jdbc-instrumentation 

📦 integration-tests/opentelemetry-jdbc-instrumentation

✖ io.quarkus.it.opentelemetry.PostgresOpenTelemetryJdbcInstrumentationIT.testPostgreSqlQueryTraced - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code <200> but was <500>.

[Ladicek]

The PostgresOpenTelemetryJdbcInstrumentationIT.testPostgreSqlQueryTraced fails because of

2023-03-02 16:15:57,122 ERROR [io.qua.ver.htt.run.QuarkusErrorHandler] (executor-thread-0) HTTP Request to /hit/postgresql?id=1 failed, error id: 62fd67f1-03fe-40ac-a2fc-8bd3e5373a22-1:
java.lang.IllegalStateException: Cannot retrieve the EntityManagerFactory/SessionFactory for persistence unit postgresql:
Hibernate ORM was deactivated through configuration properties

The exact same failure seems to occur on a bunch of other PRs: https://github.com/quarkusio/quarkus/pulls?q=is%3Apr+PostgresOpenTelemetryJdbcInstrumentationIT+testPostgreSqlQueryTraced

Gonna merge this.