Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support custom CDI contexts implementing AlterableContext #33664

Closed
Ladicek opened this issue May 29, 2023 · 1 comment · Fixed by #34418
Closed

Support custom CDI contexts implementing AlterableContext #33664

Ladicek opened this issue May 29, 2023 · 1 comment · Fixed by #34418
Labels
area/arc Issue related to ARC (dependency injection) kind/enhancement New feature or request
Milestone

Comments

@Ladicek
Copy link
Contributor

Ladicek commented May 29, 2023

Description

Currently, ArC requires contexts to implement InjectableContext. That doesn't prevent it from passing the CDI TCK, because that is currently lacking tests for defining custom contexts through Build Compatible Extensions (jakartaee/cdi-tck#404).

This is still an issue, though. For one, the CDI TCK will be fixed, but also, this is just supposed to work even if it's not tested.

Implementation ideas

It should be possible to create a generic implementation of InjectableContext that would delegate to AlterableContext and maintain its own assignment of contextuals to contextual instances in order to satisfy the InjectableContext contract.

@Ladicek Ladicek added kind/enhancement New feature or request area/arc Issue related to ARC (dependency injection) labels May 29, 2023
@quarkus-bot
Copy link

quarkus-bot bot commented May 29, 2023

/cc @manovotn (arc), @mkouba (arc)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/arc Issue related to ARC (dependency injection) kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant