-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Arc - validate Event#select and Event#fire methods for type variables #30917
Conversation
independent-projects/arc/tests/src/test/java/io/quarkus/arc/test/event/fire/EventFireTest.java
Outdated
Show resolved
Hide resolved
4653929
to
29293cd
Compare
// expected | ||
} | ||
SecuritySensor sensor = Arc.container().select(SecuritySensor.class).get(); | ||
TypeLiteral<SecurityEvent_Illegal<T>> typeLiteral = new TypeLiteral<SecurityEvent_Illegal<T>>() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A beer to whoever can explain to me why declaring this TypeLiteral
directly inside the lambda leads to the type variable not being recognized correctly :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤷
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here. No beer for me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I even tried to reproduce this in a minimal single-file Java program, but couldn't 🤷
independent-projects/arc/runtime/src/main/java/io/quarkus/arc/impl/EventImpl.java
Outdated
Show resolved
Hide resolved
...s/src/test/java/io/quarkus/arc/test/observers/request/RequestInObserverNotificationTest.java
Outdated
Show resolved
Hide resolved
29293cd
to
709478c
Compare
This comment has been minimized.
This comment has been minimized.
independent-projects/arc/runtime/src/main/java/io/quarkus/arc/impl/EventImpl.java
Outdated
Show resolved
Hide resolved
Otherwise LGTM. |
709478c
to
e62c88d
Compare
e62c88d
to
eb0bd36
Compare
Failing Jobs - Building eb0bd36
Full information is available in the Build summary check run. Failures⚙️ JVM Tests - JDK 11 Windows #- Failing: integration-tests/mongodb-rest-data-panache
📦 integration-tests/mongodb-rest-data-panache✖
|
CI failures are unrelated |
This PR aligns event payload validation to that of TCK and Weld.
Related to #28558
From the specification:
@mkouba @Ladicek this is a follow up on my Fri Zulip rambling, curious to hear WDYT :)