ArC fixes for spec compatibility, round 8 #33051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
manovotn
reviewed
May 3, 2023
independent-projects/arc/runtime/src/main/java/io/quarkus/arc/impl/DependentContext.java
Show resolved
Hide resolved
independent-projects/arc/runtime/src/main/java/io/quarkus/arc/impl/DependentContext.java
Show resolved
Hide resolved
independent-projects/arc/runtime/src/main/java/io/quarkus/arc/impl/DependentContext.java
Show resolved
Hide resolved
independent-projects/arc/runtime/src/main/java/io/quarkus/arc/impl/DependentContext.java
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
mkouba
approved these changes
May 11, 2023
mkouba
added
the
triage/waiting-for-ci
manovotn
approved these changes
May 11, 2023
This comment has been minimized.
This comment has been minimized.
…tors() Additionally, if a delegate injection point has no qualifiers, ArC doesn't generate an implementation of `getDelegateQualifiers()`, which means that the generated class implementing `Decorator` cannot be loaded. This commit adds a `default` implementation of that method to `InjectableDecorator`, returning the set of "implicit" qualifiers (`@Any` and `@Default`), just like `InjectableBean.getQualifiers()`. Finally, this commit allows finding a decorator instance by `String` ID (using `ArcContainer.bean(String)`), just like beans and interceptors.
First and foremost, this entails transferring the full set of bindings from build time to runtime (through `ComponentsProvider`). This means that custom interceptor bindings (not annotated `@InterceptorBinding`) are known at runtime. This commit uses that runtime information to make the `BeanManager` behave as specified: the `isInterceptorBinding()` method works properly, and the `resolveInterceptors()` method does proper input validation.
They must be `@Dependent` per the specification. We already have similar validation for producers, this commit adds it for managed beans.
|
✔️ The latest workflow run for the pull request has completed successfully. It should be safe to merge provided you have a look at the other checks in the summary. |
quarkus-bot
bot
removed
the
triage/waiting-for-ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #28558
@Dependentpseudo-scope@Priorityin strict modeBeanManager.resolveInterceptors()andresolveDecorators()@Dependent