ArC TCKs #31589
Merged
ArC TCKs #31589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One thing that is perhaps not very nice is that the |
|
Just a suggestion, but given it is somehow part of the MP effort, maybe we could have the TCK parts in |
|
I will eventually add a CDI TCK runner with full Quarkus into Maybe I should add both at the same time, but that requires keeping 2 exclusion lists in sync or some way to reuse the same exclusion list on both places. |
This comment has been minimized.
This comment has been minimized.
|
The sheer number of failures on Windows is because I admit I never tried the Arquillian adapter on Windows :-) Will take a look. |
manovotn
reviewed
Mar 6, 2023
independent-projects/arc/atinject-tck-runner/src/test/java/io/quarkus/arc/tck/Spare.java
Show resolved
Hide resolved
manovotn
reviewed
Mar 6, 2023
|
The JDK 17+ failure is also related.
The failure happens when the TCK asserts that a set of qualifiers ( |
|
I have a fix for the Windows failures. I'll look at the |
Didn't manage to figure that out before I went AFK today, we can sync on it tomorrow. |
Apparently, a lot of people use the construct `new AnnotationLiteral<MyAnnotation>() {}`
to create an annotation literal for a memberless annotation. This is wrong, because
the result doesn't implement the annotation interface, as specified by the contract
of the `Annotation.equals()` method:
> Returns true if the specified object represents an annotation that is logically
> equivalent to this one. In other words, returns true if the specified object
> is an instance of the same annotation interface as this instance, all of whose
> members are equal to the corresponding member of this annotation, as defined below:
> [...]
Yet, this occurs both in ArC tests and in the CDI TCK. This commit therefore
improves the generated `equals()` method of ArC annotation literals for this
particular case. If the annotation type has no members, the generated `equals()`
method no longer verifies that the other object's class implements the annotation
interface. Instead, it verifies that the other object's class implements
`java.lang.annotation.Annotation` and that the `annotationType()` classes
are equal. This is also what CDI's `AnnotationLiteral` does.
The TCK runner contains a sizeable exclude list. It will shrink over time.
|
Both problems should be fixed now:
|
manovotn
approved these changes
Mar 7, 2023
manovotn
added
the
triage/waiting-for-ci
|
The JDK 17 Windows failure is the same as in #31602: So this clearly is not caused by this PR, but needs looking at. I'll see if I can figure it out, but Config is scary. |
Failing Jobs - Building 603ecfa
Full information is available in the Build summary check run. Failures⚙️ Gradle Tests - JDK 11 Windows #📦 integration-tests/gradle✖ ✖ ⚙️ JVM Tests - JDK 17 Windows #- Failing: extensions/arc/deployment
! Skipped: devtools/cli extensions/agroal/deployment extensions/amazon-lambda-http/deployment and 428 more📦 extensions/arc/deployment✖ |
|
All the failures are known flaky tests, merging this. |
quarkus-bot
bot
removed
the
triage/waiting-for-ci
|
When it comes to |
+10 |
|
I'll move them in some next PR. |
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #28558