ArC fixes for spec compatibility, round 6 #31814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All the code in ArC that supports executing build compatible extensions is present in the `processor` module, which is only available at build time. There's however one class that needs to be present at runtime: `ParametersImpl`, the implementation of CDI's `Parameters`. This commit moves the class from `processor` to `runtime`.
|
I'm submitting this separately with a very small number of changes so that this can make it into 3.0.0.Alpha6. The issue with runtime visibility of that one class unfortunately wasn't caught before, only after I tried it in a completely standalone Quarkus application. All the testing infrastructure we have in ArC depends on |
mkouba
approved these changes
Mar 13, 2023
gsmet
reviewed
Mar 13, 2023
This avoid clutter in the main ArC module. TCKs are important, but easy navigation around the ArC code base is important too.
Ladicek
added
the
triage/waiting-for-ci
quarkus-bot
bot
removed
the
triage/waiting-for-ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #28558
processormoduletcksdirectory, this is a follow-up on ArC TCKs #31589