-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docker into develop 02 #951
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will merge all the docker components into a new branch in the main repo. As part of milestone 0.7 these items will be cleaned up as a step towards making the docker version the default (i.e. `develop`) version for milestone 0.8. This is being merged now because there are too many changes within one PR and it will be better to have new PRs that branch off this `docker` branch. This will also allow for installs on new units from the `panoptes` user rather than my personal branches.
Keeping `docker` in line with `develop`.
Adding local user id
…assigned list. Note that this should ideally be happening by the `__del__` of the `AbstractSDCCamera` but is not getting called.
…en fully initialized. * Logging statements for debug (will be removed).
Codecov Report
@@ Coverage Diff @@
## develop #951 +/- ##
============================================
- Coverage 83.07% 68.36% -14.72%
============================================
Files 80 95 +15
Lines 6353 9500 +3147
Branches 838 873 +35
============================================
+ Hits 5278 6495 +1217
- Misses 855 2841 +1986
+ Partials 220 164 -56
Continue to review full report at Codecov.
|
This was referenced Feb 16, 2020
Closed
…r-into-develop-02
* Don't start time service on linux * Don't write existing env vars to zshrc * Don't fetch origin if repo already exists * Always pull docker images * Don't use sudo for pulling images
This was referenced Jun 1, 2020
Closed
Closed
Closed
Closed
Closed
This was referenced Jun 14, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merging the
docker
branch intodevelop
.This PR is effectively
v0.7.0
Related Issue
Replaces #950
Closes #927
Closes #934
Closes #948
Closes #531
Closes #137
Closes #734
Closes #960
Closes #828
Closes #952
Closes #897
Closes #809
Closes #970
Related to #115
Relies on panoptes/panoptes-utils#189
Types of changes