String formatting errors in exception arguments

[AnthonyHorton]

Describe the bug
In POCS there are a few instance of

raise ValueError("Blah, blah, blah, {}!", obj)

where it should be

raise ValueError("Blah, blah, blah, {}!".format(obj))

or

raise ValueError(f"Blah, blah, blah, {obj}!"), e.g.

POCS/pocs/focuser/focuser.py

Line 242 in 22532da

"No focus exposure time specified, aborting autofocus of {}!", self._camera)

and

POCS/pocs/focuser/focuser.py

Line 249 in 22532da

"No focus thumbnail size specified, aborting autofocus of {}!", self._camera)

These don't cause problems in POCS itself (beyond some funny looking exceptions) but they do cause problems for the remote cameras in huntsman-pocs, because the Pyro4 network layer ends up trying to serialise ValueErrors that contain, in their args list, a reference to an object that it can't serialise, resulting in opaque 'circular reference' exceptions from Pyro.

[wtgee]

Thanks for reporting!

[AnthonyHorton]

For extra credit someone should craft a regular expression for finding all instances of this! I've found four so far, but I'm not sure that's all of them.

Edit: self nerd-snipe! The regular expression }.*(["']), [^\1]+\) finds 102 matches in the POCS codebase. There are definitely a few false positives, but most of them seem to be string formatting mistakes!

[wtgee]

Related to this we also have a number of places where we are still passing multiple arguments to the logger, as in:

self.logger.debug("Here's some foo", bar)

They are also not really causing problems but it would be good to get them switched to f-strings.

[wtgee]

I tried to take care of a lot of these in #951.

[wtgee]

I think I got the rest of these in #983. The regex doesn't turn up anything else. Feel free to reopen.