Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase level of detail in logs and exception messages when cameras not ready #969

Closed
AnthonyHorton opened this issue May 14, 2020 · 2 comments

Comments

@AnthonyHorton
Copy link
Collaborator

The AbstractCamera base class includes a properties to check whether a camera is ready to take another exposure, is_ready. This property is checked in take_exposure(), where an exception will be raised if the camera is not ready. Currently this exception simply states that an exposure was attempted when the camera was not ready, it does not say why the camera was not ready (e.g. exposure already in progress, image sensor temperature not stable, filterwheel or focuser not ready).

The camera readiness checks also do very little logging, the only possible log message in addition to the error message from take_exposure() is a warning that the image sensor temperature is unstable, and even this does not include the target temperature, actual temperature and cooling power.

This lack of information is presenting a problem for Huntsman debugging, as camera not ready exceptions are being seen but lack the information to identify the root cause.

Describe the solution you'd like
The exception raised by take_exposure() if the camera is not ready to take an exposure should include the reasons why the camera was not ready. Additionally the camera logs should include full details of any failed readiness checks.

@wtgee
Copy link
Member

wtgee commented May 29, 2020

Actually I think that I have added a bunch of this in #950 but that was mostly motivated by the fact that I was experiencing a large number of those failures with the cameras.

Most of what I have added is related to the cooling as I had found that it was mostly a race-condition. Unfortunately that PR is such a gigantic mess that it's hard to point to the individual change.

I'll update this issue later.

@wtgee
Copy link
Member

wtgee commented Jun 1, 2020

Closed by #951

@wtgee wtgee closed this as completed Jun 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants