Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solve field fixes. #189

Merged
merged 6 commits into from
May 8, 2020
Merged

Conversation

wtgee
Copy link
Member

@wtgee wtgee commented May 8, 2020

  • get_solve_field will only accept kwargs for passing to solve_field. Single keyword options should have a bool, e.g. {'--overwrite': True}

wtgee added 3 commits May 7, 2020 14:34
@wtgee wtgee mentioned this pull request May 8, 2020
2 tasks
@codecov
Copy link

codecov bot commented May 8, 2020

Codecov Report

Merging #189 into develop will increase coverage by 0.21%.
The diff coverage is 81.81%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #189      +/-   ##
===========================================
+ Coverage    72.39%   72.60%   +0.21%     
===========================================
  Files           26       26              
  Lines         1811     1814       +3     
  Branches       240      240              
===========================================
+ Hits          1311     1317       +6     
+ Misses         439      435       -4     
- Partials        61       62       +1     
Impacted Files Coverage Δ
panoptes/utils/images/fits.py 82.05% <81.81%> (+1.32%) ⬆️
panoptes/utils/error.py 94.59% <0.00%> (+1.35%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ce6971...8ae0763. Read the comment docs.

@wtgee wtgee merged commit e99f03b into panoptes:develop May 8, 2020
@wtgee wtgee deleted the fix-solve-timeout-errors branch May 8, 2020 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant