Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Backports #1079)Chained Alert Behaviour Changes #1091

Closed
wants to merge 104 commits into from

Conversation

eirsep
Copy link
Member

@eirsep eirsep commented Aug 16, 2023

Backports #1079 as main branch is unstable pending on fixes from Opensearch core's breaking change refactor on dependencies.

opensearch-trigger-bot bot and others added 30 commits July 6, 2022 14:42
…#487)

* Added 2.1 release notes.

Signed-off-by: AWSHurneyt <[email protected]>

* Added 2.1 release notes.

Signed-off-by: AWSHurneyt <[email protected]>
(cherry picked from commit 9f3c393)

Co-authored-by: AWSHurneyt <[email protected]>
…ensearch-project#503)

* Version increment automation

Signed-off-by: pgodithi <[email protected]>

* Version increment automation: task rename updateVersion

Signed-off-by: pgodithi <[email protected]>
(cherry picked from commit 3b8bfe7)
Signed-off-by: prudhvigodithi <[email protected]>

Co-authored-by: Prudhvi Godithi <[email protected]>
…rch-project#499)

As per gradle [docs] add support to remove timestamps and package with same order which is required from
[reproducible] builds

[docs]: https://docs.gradle.org/current/userguide/working_with_files.html#sec:archives
[reproducible]: https://reproducible-builds.org/

Signed-off-by: Leonidas Spyropoulos <[email protected]>
(cherry picked from commit a27d5a2)
Signed-off-by: prudhvigodithi <[email protected]>

Co-authored-by: Leonidas Spyropoulos <[email protected]>
….1.0.0 zip following deprecation of ODFE. (opensearch-project#510) (opensearch-project#512)

Signed-off-by: AWSHurneyt <[email protected]>
(cherry picked from commit fea6b4a)

Co-authored-by: AWSHurneyt <[email protected]>
* Added 2.2 release notes.

Signed-off-by: AWSHurneyt <[email protected]>

* Added 2.2 release notes.

Signed-off-by: AWSHurneyt <[email protected]>
* Bumped 2.x branch from version 2.2.0 to 2.3.0.

Signed-off-by: AWSHurneyt <[email protected]>

* Bumped mockito core version.

Signed-off-by: AWSHurneyt <[email protected]>

Signed-off-by: AWSHurneyt <[email protected]>
* Added 2.3 release notes.

Signed-off-by: AWSHurneyt <[email protected]>

* Added 2.3 release notes.

Signed-off-by: AWSHurneyt <[email protected]>

Signed-off-by: AWSHurneyt <[email protected]>
…roject#570) (opensearch-project#571)

Signed-off-by: Peter Zhu <[email protected]>

Signed-off-by: Peter Zhu <[email protected]>
(cherry picked from commit 3a844f8)

Co-authored-by: Peter Zhu <[email protected]>
…search-project#603)

Signed-off-by: prudhvigodithi <[email protected]>

Signed-off-by: prudhvigodithi <[email protected]>
(cherry picked from commit 01a28e9)

Co-authored-by: Prudhvi Godithi <[email protected]>
…t#598) (opensearch-project#599)

Signed-off-by: Subhobrata Dey <[email protected]>
(cherry picked from commit 4165eac)

Co-authored-by: Subhobrata Dey <[email protected]>
…nsearch-project#590) (opensearch-project#605)

Signed-off-by: Surya Sashank Nistala <[email protected]>
(cherry picked from commit f4a3509)

Co-authored-by: Surya Sashank Nistala <[email protected]>
…endencies (opensearch-project#606) (opensearch-project#607)

Signed-off-by: Surya Sashank Nistala <[email protected]>
(cherry picked from commit e94ea32)

Co-authored-by: Surya Sashank Nistala <[email protected]>
…ensearch-project#608) (opensearch-project#609)

* suport fetching alerts by alert ids in Get Alerts Action

* acknowledge alerts from custom alerts index
Signed-off-by: Surya Sashank Nistala <[email protected]>
(cherry picked from commit 3c74744)

Co-authored-by: Surya Sashank Nistala <[email protected]>
Signed-off-by: Petar Dzepina <[email protected]>

(cherry picked from commit 996190e)

Co-authored-by: Petar Dzepina <[email protected]>
…ate as AckAlertRequest (opensearch-project#618) (opensearch-project#619)

Signed-off-by: Surya Sashank Nistala <[email protected]>

Signed-off-by: Surya Sashank Nistala <[email protected]>
(cherry picked from commit 2005185)

Co-authored-by: Surya Sashank Nistala <[email protected]>
)

Signed-off-by: Petar Dzepina <[email protected]>
(cherry picked from commit 7546b00)

Co-authored-by: Petar Dzepina <[email protected]>
…rces (opensearch-project#626) (opensearch-project#627)

* in case of custom indices, allow moving alerts to history index

Signed-off-by: Petar Dzepina <[email protected]>

* empty commit

Signed-off-by: Petar Dzepina <[email protected]>

* added IT for custom datasources alert ack

Signed-off-by: Petar Dzepina <[email protected]>

Signed-off-by: Petar Dzepina <[email protected]>
(cherry picked from commit 0740d9b)

Co-authored-by: Petar Dzepina <[email protected]>
…t#628) (opensearch-project#630)

* refactored DeleteMonitor Action to be synchronious

Signed-off-by: Petar Dzepina <[email protected]>

Signed-off-by: Petar Dzepina <[email protected]>
Co-authored-by: Petar Dzepina <[email protected]>
…oject#641) (opensearch-project#642)

Signed-off-by: Surya Sashank Nistala <[email protected]>

Signed-off-by: Surya Sashank Nistala <[email protected]>
(cherry picked from commit f80b3e0)

Co-authored-by: Surya Sashank Nistala <[email protected]>
eirsep and others added 21 commits June 20, 2023 22:47
…ch-project#965)

* Added rest layer for the workflow. Added secure tests (opensearch-project#886)

* Added rest layer for the workflow. Added secure tests

* add execution_id field in alert mapping
---------

Signed-off-by: Stevan Buzejic <[email protected]>
Signed-off-by: Surya Sashank Nistala <[email protected]>
Co-authored-by: Stevan Buzejic <[email protected]>
…search-project#970)

Signed-off-by: Surya Sashank Nistala <[email protected]>
(cherry picked from commit 62d2524)

Co-authored-by: Surya Sashank Nistala <[email protected]>
…search-project#990)

* Fixed search monitor API to return alert counts. (opensearch-project#978)

* Fixed a bug in the search monitor API when which prevent alert counts from being returned.

Signed-off-by: AWSHurneyt <[email protected]>

* Implemented integration test for frontend use case.

Signed-off-by: AWSHurneyt <[email protected]>

* Fixed ktlint errors.

Signed-off-by: AWSHurneyt <[email protected]>

* Fixed ktlint errors.

Signed-off-by: AWSHurneyt <[email protected]>

* Removed redundant code.

Signed-off-by: AWSHurneyt <[email protected]>

* Fixed ktlint errors.

Signed-off-by: AWSHurneyt <[email protected]>

* Added back check for null query.

Signed-off-by: AWSHurneyt <[email protected]>

---------

Signed-off-by: AWSHurneyt <[email protected]>

* Fixed string entity call.

Signed-off-by: AWSHurneyt <[email protected]>

---------

Signed-off-by: AWSHurneyt <[email protected]>
…rch-project#989) (opensearch-project#993)

* check if ad filter is enabled

* updated integ tests

---------

Signed-off-by: Amit Galitzky <[email protected]>
(cherry picked from commit 62d3d7e)

Co-authored-by: Amit Galitzky <[email protected]>
…on id and workflow id (opensearch-project#994) (opensearch-project#995)

Signed-off-by: Subhobrata Dey <[email protected]>
Co-authored-by: Surya Sashank Nistala <[email protected]>
…ct#997) (opensearch-project#1000)

Signed-off-by: Ashish Agrawal <[email protected]>
(cherry picked from commit c535349)

Co-authored-by: Ashish Agrawal <[email protected]>
…pensearch-project#1002)

* added handling of multi-term agg in bucketlevel monitors

Signed-off-by: Petar Dzepina <[email protected]>

* added handling of multi-term agg in bucketlevel monitors

Signed-off-by: Petar Dzepina <[email protected]>

* added more asserts

Signed-off-by: Petar Dzepina <[email protected]>

---------

Signed-off-by: Petar Dzepina <[email protected]>
(cherry picked from commit a3db266)

Co-authored-by: Petar Dzepina <[email protected]>
…-project#1007) (opensearch-project#1008)

* Adds chained alerts (opensearch-project#976)

* chained alert triggers

Signed-off-by: Surya Sashank Nistala <[email protected]>

* converge all single node test cases

Signed-off-by: Surya Sashank Nistala <[email protected]>

* add license headers to files

Signed-off-by: Surya Sashank Nistala <[email protected]>

* fix workflow not found issue

Signed-off-by: Surya Sashank Nistala <[email protected]>

* added audit state alerts for doc level monitors

Signed-off-by: Surya Sashank Nistala <[email protected]>

* add audit alerts in query level monitor

Signed-off-by: Surya Sashank Nistala <[email protected]>

* temp: upload custom built common utils jar

Signed-off-by: Surya Sashank Nistala <[email protected]>

* fix get monitor response parsing to include associated_workflows

Signed-off-by: Surya Sashank Nistala <[email protected]>

* add query level monitor audit alerts tests

Signed-off-by: Surya Sashank Nistala <[email protected]>

* add audit alerts in bucket level monitor

Signed-off-by: Surya Sashank Nistala <[email protected]>

* fix workflow tests

Signed-off-by: Surya Sashank Nistala <[email protected]>

* alerting

Signed-off-by: Surya Sashank Nistala <[email protected]>

* verify bucket monitor audit alerts and chained alerts in workflow

Signed-off-by: Surya Sashank Nistala <[email protected]>

* make execution id mandatory

Signed-off-by: Surya Sashank Nistala <[email protected]>

* revert mapping update in run job method

Signed-off-by: Surya Sashank Nistala <[email protected]>

* minor fixes in chained alert trigger result

Signed-off-by: Surya Sashank Nistala <[email protected]>

* fix chained alert triggers tests

Signed-off-by: Surya Sashank Nistala <[email protected]>

* fix acknowledge chained alert bug

Signed-off-by: Surya Sashank Nistala <[email protected]>

* revert get alerts change

Signed-off-by: Surya Sashank Nistala <[email protected]>

* refactor and remove transport actions being invoked in other transport actions

Signed-off-by: Surya Sashank Nistala <[email protected]>

* add license header

Signed-off-by: Surya Sashank Nistala <[email protected]>

* scheduled job mapping schema

Signed-off-by: Surya Sashank Nistala <[email protected]>

* fix ktlint and revert gradle dev set up chanegs

Signed-off-by: Surya Sashank Nistala <[email protected]>

* fix post delete method and refactor alert mover to add class level logger

Signed-off-by: Surya Sashank Nistala <[email protected]>

* fix test - pass workflow id in get alerts

Signed-off-by: Surya Sashank Nistala <[email protected]>

* remove monitor empty filter in get alerts api as there is dedicated api for fetching chained alerts - workflow alerts api

Signed-off-by: Surya Sashank Nistala <[email protected]>

* fix check for workflow id is empty or null in get alerts action

Signed-off-by: Surya Sashank Nistala <[email protected]>

* fix alert mover method delegate monitor parsing logic

Signed-off-by: Surya Sashank Nistala <[email protected]>

* remove common utils jar from repo

Signed-off-by: Surya Sashank Nistala <[email protected]>

---------

Signed-off-by: Surya Sashank Nistala <[email protected]>

* fix imports

Signed-off-by: Surya Sashank Nistala <[email protected]>

---------

Signed-off-by: Surya Sashank Nistala <[email protected]>
(cherry picked from commit d2d03c6)

Co-authored-by: Surya Sashank Nistala <[email protected]>
…monitor to call cat/indices, and cat/shards. opensearch-project#992 (opensearch-project#1009) (opensearch-project#1011)

* Implemented support for configuring a cluster metrics monitor to call cat/indices, and cat/shards. (opensearch-project#992)

* Implemented support for configuring a cluster metrics monitor to call cat/indices, and cat/shards.

Signed-off-by: AWSHurneyt <[email protected]>

* Fixed ktlint errors.

Signed-off-by: AWSHurneyt <[email protected]>

* Refactored executeTransportAction to use suspendUntil() instead of get() to receive responses.

Signed-off-by: AWSHurneyt <[email protected]>

---------

Signed-off-by: AWSHurneyt <[email protected]>

* Resolved merge conflicts.

Signed-off-by: AWSHurneyt <[email protected]>

* Fixed ktlint errors.

Signed-off-by: AWSHurneyt <[email protected]>

* Refactored API calls from suspendUntil() to get().

Signed-off-by: AWSHurneyt <[email protected]>

---------

Signed-off-by: AWSHurneyt <[email protected]>
(cherry picked from commit 84e8b00)

Co-authored-by: AWSHurneyt <[email protected]>
…t#1013)

* Added 2.9 release notes.

Signed-off-by: AWSHurneyt <[email protected]>

* Added 2.9 release notes.

Signed-off-by: AWSHurneyt <[email protected]>

---------

Signed-off-by: AWSHurneyt <[email protected]>
(cherry picked from commit 2d3af5b)

Co-authored-by: AWSHurneyt <[email protected]>
…nsearch-project#1017)

* add alert mover test for verifying workflow post delete clean up

Signed-off-by: Surya Sashank Nistala <[email protected]>

* add workflowIds field in get alerts API

Signed-off-by: Surya Sashank Nistala <[email protected]>

* add support for fetching workflows in search monitors api

Signed-off-by: Surya Sashank Nistala <[email protected]>

---------

Signed-off-by: Surya Sashank Nistala <[email protected]>
(cherry picked from commit 2430d81)

Co-authored-by: Surya Sashank Nistala <[email protected]>
… and skip audit state alerts (opensearch-project#1020) (opensearch-project#1023)

* fix get alerts api with default params to return chained alerts and skip audit alerts

Signed-off-by: Surya Sashank Nistala <[email protected]>

* fix alert state query filter for get workflow alerts to avoid audit alerts and fetch only chained alerts

Signed-off-by: Surya Sashank Nistala <[email protected]>

* fix typo

Signed-off-by: Surya Sashank Nistala <[email protected]>

---------

Signed-off-by: Surya Sashank Nistala <[email protected]>
(cherry picked from commit 0add91f)

Co-authored-by: Surya Sashank Nistala <[email protected]>
…urn both workflows and monitors on search (opensearch-project#1026) (opensearch-project#1027)

* add workflow type field exists check in search monitors action to retunr both workflows and monitors on search

Signed-off-by: Surya Sashank Nistala <[email protected]>

* remove .get() invocation on future and replace with suspendUntil call for search Associated monitors

Signed-off-by: Surya Sashank Nistala <[email protected]>

* add workflowIds param in rest get alerts action

Signed-off-by: Surya Sashank Nistala <[email protected]>

---------

Signed-off-by: Surya Sashank Nistala <[email protected]>
(cherry picked from commit 064e5f5)

Co-authored-by: Surya Sashank Nistala <[email protected]>
…reWorkflowRestApiIT (opensearch-project#1041) (opensearch-project#1042)

* fix password argument in SecureRestClientBuilder constructor for SecureWorkflowRestApiIT

Signed-off-by: Surya Sashank Nistala <[email protected]>

* fix tests to account for AUDIT alerts

Signed-off-by: Surya Sashank Nistala <[email protected]>

---------

Signed-off-by: Surya Sashank Nistala <[email protected]>
(cherry picked from commit e4fae0e)

Co-authored-by: Surya Sashank Nistala <[email protected]>
…ct#1067) (opensearch-project#1069)

(cherry picked from commit 3baf51a)

Signed-off-by: Ashish Agrawal <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…d alerts if alertId param is mentioned (opensearch-project#1071) (opensearch-project#1074)

* add alertId parameter in get chained alert API and paginate associated alerts if alertId param is mentioned



* set from param in associated alerts search request



---------


(cherry picked from commit d9f66b3)

Signed-off-by: Surya Sashank Nistala <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: Surya Sashank Nistala <[email protected]>
Signed-off-by: Surya Sashank Nistala <[email protected]>
Signed-off-by: Surya Sashank Nistala <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants