-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add workflowIds field in getAlerts API #1014
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eirsep
requested review from
lezzago,
AWSHurneyt,
sbcd90,
getsaurabh02,
praveensameneni,
qreshi,
bowenlan-amzn and
rishabhmaurya
as code owners
July 12, 2023 16:16
Signed-off-by: Surya Sashank Nistala <[email protected]>
Signed-off-by: Surya Sashank Nistala <[email protected]>
Signed-off-by: Surya Sashank Nistala <[email protected]>
getsaurabh02
approved these changes
Jul 12, 2023
amsiglan
approved these changes
Jul 12, 2023
lezzago
approved these changes
Jul 12, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 12, 2023
* add alert mover test for verifying workflow post delete clean up Signed-off-by: Surya Sashank Nistala <[email protected]> * add workflowIds field in get alerts API Signed-off-by: Surya Sashank Nistala <[email protected]> * add support for fetching workflows in search monitors api Signed-off-by: Surya Sashank Nistala <[email protected]> --------- Signed-off-by: Surya Sashank Nistala <[email protected]> (cherry picked from commit 2430d81)
This was referenced Jul 12, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 12, 2023
* add alert mover test for verifying workflow post delete clean up Signed-off-by: Surya Sashank Nistala <[email protected]> * add workflowIds field in get alerts API Signed-off-by: Surya Sashank Nistala <[email protected]> * add support for fetching workflows in search monitors api Signed-off-by: Surya Sashank Nistala <[email protected]> --------- Signed-off-by: Surya Sashank Nistala <[email protected]> (cherry picked from commit 2430d81)
eirsep
added a commit
that referenced
this pull request
Jul 12, 2023
* add alert mover test for verifying workflow post delete clean up Signed-off-by: Surya Sashank Nistala <[email protected]> * add workflowIds field in get alerts API Signed-off-by: Surya Sashank Nistala <[email protected]> * add support for fetching workflows in search monitors api Signed-off-by: Surya Sashank Nistala <[email protected]> --------- Signed-off-by: Surya Sashank Nistala <[email protected]> (cherry picked from commit 2430d81) Co-authored-by: Surya Sashank Nistala <[email protected]>
bowenlan-amzn
pushed a commit
that referenced
this pull request
Aug 2, 2023
* add alert mover test for verifying workflow post delete clean up Signed-off-by: Surya Sashank Nistala <[email protected]> * add workflowIds field in get alerts API Signed-off-by: Surya Sashank Nistala <[email protected]> * add support for fetching workflows in search monitors api Signed-off-by: Surya Sashank Nistala <[email protected]> --------- Signed-off-by: Surya Sashank Nistala <[email protected]> (cherry picked from commit 2430d81) Co-authored-by: Surya Sashank Nistala <[email protected]>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added workflowIds field in Get Alerts rest API
This allows users to fetch chained alerts when listing workflows and monitor in the dashboard