Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Add workflowIds field in getAlerts API #1016

Merged
merged 1 commit into from
Aug 2, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 2430d81 from #1014

* add alert mover test for verifying workflow post delete clean up

Signed-off-by: Surya Sashank Nistala <[email protected]>

* add workflowIds field in get alerts API

Signed-off-by: Surya Sashank Nistala <[email protected]>

* add support for fetching workflows in search monitors api

Signed-off-by: Surya Sashank Nistala <[email protected]>

---------

Signed-off-by: Surya Sashank Nistala <[email protected]>
(cherry picked from commit 2430d81)
@codecov
Copy link

codecov bot commented Jul 12, 2023

Codecov Report

Merging #1016 (1b1de50) into 2.x (3ba65f2) will increase coverage by 0.09%.
The diff coverage is 91.66%.

@@             Coverage Diff              @@
##                2.x    #1016      +/-   ##
============================================
+ Coverage     72.56%   72.65%   +0.09%     
  Complexity      119      119              
============================================
  Files           160      160              
  Lines         10424    10431       +7     
  Branches       1569     1570       +1     
============================================
+ Hits           7564     7579      +15     
+ Misses         1971     1959      -12     
- Partials        889      893       +4     
Impacted Files Coverage Δ
...search/alerting/resthandler/RestGetAlertsAction.kt 97.05% <80.00%> (-2.95%) ⬇️
...otlin/org/opensearch/alerting/alerts/AlertMover.kt 67.91% <100.00%> (+0.24%) ⬆️
...alerting/transport/TransportSearchMonitorAction.kt 78.72% <100.00%> (+0.94%) ⬆️

... and 9 files with indirect coverage changes

@bowenlan-amzn bowenlan-amzn merged commit 6c6198d into 2.x Aug 2, 2023
@github-actions github-actions bot deleted the backport/backport-1014-to-2.x branch August 2, 2023 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants