Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix password argument in SecureRestClientBuilder constructor for SecureWorkflowRestApiIT #1041

Merged
merged 2 commits into from
Jul 17, 2023

Conversation

eirsep
Copy link
Member

@eirsep eirsep commented Jul 17, 2023

fix password argument in SecureRestClientBuilder constructor for SecureWorkflowRestApiIT

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@eirsep eirsep added the backport 2.9 backports PRs to 2.9 label Jul 17, 2023
@codecov
Copy link

codecov bot commented Jul 17, 2023

Codecov Report

Merging #1041 (fc120af) into 2.x (064e5f5) will increase coverage by 0.03%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                2.x    #1041      +/-   ##
============================================
+ Coverage     72.66%   72.70%   +0.03%     
  Complexity      119      119              
============================================
  Files           160      160              
  Lines         10447    10447              
  Branches       1572     1572              
============================================
+ Hits           7591     7595       +4     
+ Misses         1965     1959       -6     
- Partials        891      893       +2     

see 5 files with indirect coverage changes

…reWorkflowRestApiIT

Signed-off-by: Surya Sashank Nistala <[email protected]>
Signed-off-by: Surya Sashank Nistala <[email protected]>
@eirsep eirsep merged commit e4fae0e into opensearch-project:2.x Jul 17, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 17, 2023
…reWorkflowRestApiIT (#1041)

* fix password argument in SecureRestClientBuilder constructor for SecureWorkflowRestApiIT

Signed-off-by: Surya Sashank Nistala <[email protected]>

* fix tests to account for AUDIT alerts

Signed-off-by: Surya Sashank Nistala <[email protected]>

---------

Signed-off-by: Surya Sashank Nistala <[email protected]>
(cherry picked from commit e4fae0e)
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 17, 2023
…reWorkflowRestApiIT (#1041)

* fix password argument in SecureRestClientBuilder constructor for SecureWorkflowRestApiIT

Signed-off-by: Surya Sashank Nistala <[email protected]>

* fix tests to account for AUDIT alerts

Signed-off-by: Surya Sashank Nistala <[email protected]>

---------

Signed-off-by: Surya Sashank Nistala <[email protected]>
(cherry picked from commit e4fae0e)
eirsep added a commit that referenced this pull request Jul 19, 2023
…reWorkflowRestApiIT (#1041) (#1042)

* fix password argument in SecureRestClientBuilder constructor for SecureWorkflowRestApiIT

Signed-off-by: Surya Sashank Nistala <[email protected]>

* fix tests to account for AUDIT alerts

Signed-off-by: Surya Sashank Nistala <[email protected]>

---------

Signed-off-by: Surya Sashank Nistala <[email protected]>
(cherry picked from commit e4fae0e)

Co-authored-by: Surya Sashank Nistala <[email protected]>
lezzago pushed a commit that referenced this pull request Jul 26, 2023
…reWorkflowRestApiIT (#1041) (#1043)

* fix password argument in SecureRestClientBuilder constructor for SecureWorkflowRestApiIT

Signed-off-by: Surya Sashank Nistala <[email protected]>

* fix tests to account for AUDIT alerts

Signed-off-by: Surya Sashank Nistala <[email protected]>

---------

Signed-off-by: Surya Sashank Nistala <[email protected]>
(cherry picked from commit e4fae0e)

Co-authored-by: Surya Sashank Nistala <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport main backport 2.9 backports PRs to 2.9
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants